Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: go1.22.6 downgrade #39256

Merged
merged 12 commits into from
Sep 10, 2024
Merged

provider: go1.22.6 downgrade #39256

merged 12 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. chore: revert to go1.22.6

    A small number of users have reported failed or hanging network connections using the version of the Terraform AWS provider which was first built with Go `1.23.0` (`v5.65.0`). At this point, maintainers have been unable to reproduce failures, but enough distinct users have reported issues that we are going to attempt downgrading to Go `1.22.6` for the next provider release. We will continue to coordinate with users and AWS in an attempt to identify the root cause, using this upcoming release with a reverted Go build version as a data point.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8ef5573 View commit details
    Browse the repository at this point in the history
  2. Revert "Remove 'tfslices.Chunks'."

    This reverts commit e5c24d5.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9be946f View commit details
    Browse the repository at this point in the history
  3. Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - ssm."

    This reverts commit 281ea60.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bfff87f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d1b3b11 View commit details
    Browse the repository at this point in the history
  5. Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - rds."

    This reverts commit ed58544.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0c6c637 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8ec8670 View commit details
    Browse the repository at this point in the history
  7. Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - kafka."

    This reverts commit 623df99.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f797f26 View commit details
    Browse the repository at this point in the history
  8. Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - docdb."

    This reverts commit 7d5e310.
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9ec42d9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c40facf View commit details
    Browse the repository at this point in the history
  10. Partial reversion of Replace 'tfslices.Chunks' with 'slices.Chunk' - …

    …lakeformation.
    
    ```console
    % make testacc TESTARGS='-run=TestAccLakeFormation_serial/^LFTags$$' PKG=lakeformation
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.6 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/^LFTags$ -timeout 360m
    
    --- PASS: TestAccLakeFormation_serial (97.10s)
        --- PASS: TestAccLakeFormation_serial/LFTags (97.10s)
            --- PASS: TestAccLakeFormation_serial/LFTags/basic (15.97s)
            --- PASS: TestAccLakeFormation_serial/LFTags/disappears (13.05s)
            --- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (12.14s)
            --- PASS: TestAccLakeFormation_serial/LFTags/values (24.46s)
            --- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (31.49s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      103.355s
    ```
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b142d28 View commit details
    Browse the repository at this point in the history
  11. Partial reversion of Replace 'tfslices.Chunks' with 'slices.Chunk' - …

    …autoscaling.
    
    ```console
    % make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.6 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m
    
    --- PASS: TestAccAutoScalingGroup_basic (28.41s)
    --- PASS: TestAccAutoScalingGroup_targetGroups (108.44s)
    --- PASS: TestAccAutoScalingGroup_loadBalancers (287.88s)
    --- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (374.16s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        380.382s
    ```
    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a351eb1 View commit details
    Browse the repository at this point in the history
  12. chore: changelog

    jar-b committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0f552d3 View commit details
    Browse the repository at this point in the history