Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_domain - refresh missing arguments #39774

Merged
merged 2 commits into from
Oct 18, 2024
Merged

r/sagemaker_domain - refresh missing arguments #39774

merged 2 commits into from
Oct 18, 2024

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 17, 2024 •
edited
Loading

Description

Relations

Closes #39521

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=sagemaker
--- PASS: TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenInstanceTypes (252.65s)
--- PASS: TestAccSageMaker_serial/Domain/emrServerlessSettings (249.66s)
--- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsBuiltInLifecycle (248.42s)
--- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsAppLifecycle (250.84s)
--- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsEMRSettings (250.13s)
--- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated (268.30s)

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Oct 17, 2024
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 17, 2024
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 17, 2024
@DrFaust92
Copy link
Collaborator Author

Will add the space resource arguments in a different PR to make this huge PR not involve another resource 😖

@DrFaust92
sagemaker refresh arg
30393f1 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 marked this pull request as ready for review October 17, 2024 22:29
@DrFaust92 DrFaust92 requested a review from a team as a code owner October 17, 2024 22:29
@ewbankkit ewbankkit self-assigned this Oct 18, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 18, 2024
ewbankkit
ewbankkit approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMaker_serial/^Domain$$\|TestAccSageMaker_serial/^UserProfile$$' PKG=sagemaker 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/^Domain$\|TestAccSageMaker_serial/^UserProfile$ -timeout 360m
2024/10/18 08:49:53 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/emrServerlessSettings
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProDomainSettings
    acctest.go:1680: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating SageMaker Domain (d-nvga5c2x3csf): waiting for completion: unexpected state 'Failed', wanted target 'InService'. last error: ConfigurationError: Domain-level App [arn:aws:sagemaker:us-west-2:123456789012:app/d-nvga5c2x3csf/domain-shared/RStudioServerPro/default] failed to start: [ResourceNotFoundError: No available licenses were found. Validate that a license for RStudio Workbench exists in AWS License Manager that is in Active state.].
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 86, in resource "aws_sagemaker_domain" "test":
          86: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccSageMaker_serial/Domain/posix
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/Domain/codeEditorAppSettings
=== RUN   TestAccSageMaker_serial/Domain/generativeAi
=== RUN   TestAccSageMaker_serial/Domain/directDeploySettings
=== RUN   TestAccSageMaker_serial/Domain/code
=== RUN   TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenInstanceTypes
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage
    domain_test.go:1092: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/sharingSettings
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProAppSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsSpaceStorageSettings
=== RUN   TestAccSageMaker_serial/Domain/efs
=== RUN   TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenMlTools
=== RUN   TestAccSageMaker_serial/Domain/basic
=== RUN   TestAccSageMaker_serial/Domain/codeEditorAppSettings_defaultResourceSpecAndCustomImage
    domain_test.go:839: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/jupyterLabAppSettingsEMRSettings
=== RUN   TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenAppTypes
=== RUN   TestAccSageMaker_serial/Domain/jupyterLabAppSettingsAppLifecycle
=== RUN   TestAccSageMaker_serial/Domain/defaultUserSettingsSecurityGroupUpdated
=== RUN   TestAccSageMaker_serial/Domain/spaceStorageSettings
=== RUN   TestAccSageMaker_serial/Domain/identityProviderOauthSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Domain/kms
=== RUN   TestAccSageMaker_serial/Domain/modelRegisterSettings
=== RUN   TestAccSageMaker_serial/Domain/domainSettings
=== RUN   TestAccSageMaker_serial/Domain/domainSettingsDockerSettingsUpdated
=== RUN   TestAccSageMaker_serial/Domain/rSessionAppSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsCustomPOSIXUserConfig
=== RUN   TestAccSageMaker_serial/Domain/disappears
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/Domain/canvas
=== RUN   TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsJupyterLabAppSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsCustomFileSystemConfigs
=== RUN   TestAccSageMaker_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Domain/jupyterLabAppSettings
=== RUN   TestAccSageMaker_serial/Domain/jupyterLabAppSettingsBuiltInLifecycle
=== RUN   TestAccSageMaker_serial/Domain/kendraSettings
=== RUN   TestAccSageMaker_serial/Domain/workspaceSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/tags
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage
    domain_test.go:1053: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/codeEditorAppSettings_customImage
    domain_test.go:800: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/basic
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage
    user_profile_test.go:282: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools
--- PASS: TestAccSageMaker_serial (13715.69s)
    --- PASS: TestAccSageMaker_serial/Domain (11084.49s)
        --- PASS: TestAccSageMaker_serial/Domain/emrServerlessSettings (249.52s)
        --- SKIP: TestAccSageMaker_serial/Domain/rStudioServerProDomainSettings (684.74s)
        --- PASS: TestAccSageMaker_serial/Domain/posix (248.91s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (238.90s)
        --- PASS: TestAccSageMaker_serial/Domain/codeEditorAppSettings (249.03s)
        --- PASS: TestAccSageMaker_serial/Domain/generativeAi (249.19s)
        --- PASS: TestAccSageMaker_serial/Domain/directDeploySettings (249.27s)
        --- PASS: TestAccSageMaker_serial/Domain/code (249.40s)
        --- PASS: TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenInstanceTypes (251.46s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (239.53s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (220.10s)
        --- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (245.00s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsSpaceStorageSettings (221.71s)
        --- PASS: TestAccSageMaker_serial/Domain/efs (329.71s)
        --- PASS: TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenMlTools (181.97s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (219.61s)
        --- SKIP: TestAccSageMaker_serial/Domain/codeEditorAppSettings_defaultResourceSpecAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsEMRSettings (239.37s)
        --- PASS: TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenAppTypes (241.73s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsAppLifecycle (228.74s)
        --- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsSecurityGroupUpdated (253.97s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceStorageSettings (229.91s)
        --- PASS: TestAccSageMaker_serial/Domain/identityProviderOauthSettings (239.68s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (228.47s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (239.70s)
        --- PASS: TestAccSageMaker_serial/Domain/modelRegisterSettings (249.38s)
        --- PASS: TestAccSageMaker_serial/Domain/domainSettings (261.87s)
        --- PASS: TestAccSageMaker_serial/Domain/domainSettingsDockerSettingsUpdated (262.04s)
        --- PASS: TestAccSageMaker_serial/Domain/rSessionAppSettings (250.49s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsCustomPOSIXUserConfig (261.17s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (271.50s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (308.30s)
        --- PASS: TestAccSageMaker_serial/Domain/canvas (249.41s)
        --- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated (257.74s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsJupyterLabAppSettings (262.74s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsCustomFileSystemConfigs (467.08s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (260.12s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettings (248.43s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettingsBuiltInLifecycle (248.76s)
        --- PASS: TestAccSageMaker_serial/Domain/kendraSettings (248.97s)
        --- PASS: TestAccSageMaker_serial/Domain/workspaceSettings (248.62s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings (260.71s)
        --- PASS: TestAccSageMaker_serial/Domain/tags (237.53s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- SKIP: TestAccSageMaker_serial/Domain/codeEditorAppSettings_customImage (0.00s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2631.21s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (260.73s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (294.58s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (260.83s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (263.31s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (260.81s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (272.15s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (262.72s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (260.88s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes (253.93s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools (241.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	13720.815s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5842279 into hashicorp:main Oct 18, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 18, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Oct 29, 2024
Closed
@justinretzolk justinretzolk mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.73.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_sagemaker_domain add idle shutdown options for JupyterLab and CodeEditor
2 participants
@DrFaust92 @ewbankkit