Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Metrics Configurations for S3 Buckets #6

Closed
bflad opened this issue Jun 10, 2017 · 4 comments
Closed

Support Metrics Configurations for S3 Buckets #6

bflad opened this issue Jun 10, 2017 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jun 10, 2017

(Migrated from hashicorp/terraform#13247)

AWS has recently announced some support for additional analytics and metrics for S3 buckets: https://aws.amazon.com/blogs/aws/s3-storage-management-update-analytics-object-tagging-inventory-and-metrics/

In order to support the above, the implementation in the AWS API is with methods like GetBucketMetricsConfiguration and PutBucketMetricsConfiguration which were added in go-aws-sdk 1.5.11.

Affected Resource(s)

  • aws_s3_bucket (but likely a new resource)

Expected Behavior

Terraform configuration should support enabling and managing AWS S3 metrics configurations.

References

@bflad
Copy link
Contributor Author

bflad commented Jun 11, 2017

Trying to implement this, I believe I hit a blocker with aws/aws-sdk-go#1334.

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 12, 2017
@bflad
Copy link
Contributor Author

bflad commented Jun 20, 2017

The SDK XML bug was fixed in 1.8.43 and this provider is now using 1.8.44+. I submitted a pull request with new aws_s3_bucket_metric resource.

@radeksimko radeksimko added the service/s3 Issues and PRs that pertain to the s3 service. label Jan 25, 2018
@bflad bflad added this to the v1.10.0 milestone Feb 27, 2018
@bflad
Copy link
Contributor Author

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad closed this as completed Feb 27, 2018
gdavison pushed a commit that referenced this issue Nov 16, 2019
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Development

No branches or pull requests

3 participants