Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in data_source_aws_network_interface #6096

Closed
asiragusa opened this issue Oct 9, 2018 · 3 comments · Fixed by #6284
Closed

Typo in data_source_aws_network_interface #6096

asiragusa opened this issue Oct 9, 2018 · 3 comments · Fixed by #6284
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@asiragusa
Copy link

I found a typo in https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/data_source_aws_network_interface.go#L178, it should be private_ip instead of private_id, also tests and docs are missing on some of those fields

@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 9, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad
Copy link
Contributor

bflad commented Oct 30, 2018

The fix for this has been merged and will release with version 1.42.0 of the AWS provider, likely today or tomorrow. 👍

bflad added a commit that referenced this issue Oct 30, 2018
issue #6096 Typo in data_source_aws_network_interface
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants