Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Version 2 Release] resource/aws_appautoscaling_policy: Remove deprecated arguments #7682

Closed
bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7706
Closed

[Version 2 Release] resource/aws_appautoscaling_policy: Remove deprecated arguments #7682

bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7706
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Feb 24, 2019

Description

Tracking issue for https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_appautoscaling_policy

Argument Removals

The following arguments have been moved into a nested argument named step_scaling_policy_configuration:

  • adjustment_type
  • cooldown
  • metric_aggregation_type
  • min_adjustment_magnitude
  • step_adjustment

For example, given this previous configuration:

resource "aws_appautoscaling_policy" "example" {
  # ... other configuration ...

  adjustment_type         = "ChangeInCapacity"
  cooldown                = 60
  metric_aggregation_type = "Maximum"

  step_adjustment {
    metric_interval_upper_bound = 0
    scaling_adjustment          = -1
  }
}

An updated configuration:

resource "aws_appautoscaling_policy" "example" {
  # ... other configuration ...

  step_scaling_policy_configuration {
    adjustment_type         = "ChangeInCapacity"
    cooldown                = 60
    metric_aggregation_type = "Maximum"

    step_adjustment {
      metric_interval_upper_bound = 0
      scaling_adjustment          = -1
    }
  }
}
@bflad bflad added service/applicationautoscaling technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
bflad added a commit that referenced this issue Feb 25, 2019
…roperly read step_scaling_policy_configuration into Terraform state

Reference: #7682

Output from acceptance testing:

```
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (28.63s)
--- PASS: TestAccAWSAppautoScalingPolicy_basic (36.45s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (60.88s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (115.12s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (116.34s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (116.89s)
```
@bflad
Copy link
Contributor Author

bflad commented Feb 25, 2019

Pull request submitted: #7706

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant