-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_route53_zone : panic: runtime error: invalid memory address or nil pointer dereference #8370
Comments
@meriouma thanks for reporting this issue. I'm pulling out the log line that highlights where the resource is throwing the panic error.
|
This may be caused by the underlying localstack service not returning a ChangeInfo object as part of the CreateHostedZoneRespsonse object. moto's route53 module appears to be missing said object from its response. Cf. the AWS Route53 API documentation |
…eation Reference: #8370 Reference: #12361 Reference: hashicorp/terraform#10798 Prevent a crash with non-compliant Route 53 APIs during creation, e.g. LocalStack. This continues best effort support by adding object reference safety, which we should be doing anyways. This change skips synchronization checking rather than raising an error, which seems like the correct and operator friendly behavior in this situation. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSRoute53Zone_disappears (48.02s) --- PASS: TestAccAWSRoute53Zone_basic (51.48s) --- PASS: TestAccAWSRoute53Zone_DelegationSetID (56.24s) --- PASS: TestAccAWSRoute53Zone_multiple (57.08s) --- PASS: TestAccAWSRoute53Zone_Comment (63.31s) --- PASS: TestAccAWSRoute53Zone_Tags (79.33s) --- PASS: TestAccAWSRoute53Zone_VPC_Single (99.31s) --- PASS: TestAccAWSRoute53Zone_VPC_Multiple (179.74s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (189.14s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy (189.54s) --- PASS: TestAccAWSRoute53Zone_VPC_Updates (265.16s) ```
Fix submitted: #12634 |
…eation (#12634) Reference: #8370 Reference: #12361 Reference: hashicorp/terraform#10798 Prevent a crash with non-compliant Route 53 APIs during creation, e.g. LocalStack. This continues best effort support by adding object reference safety, which we should be doing anyways. This change skips synchronization checking rather than raising an error, which seems like the correct and operator friendly behavior in this situation. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSRoute53Zone_disappears (48.02s) --- PASS: TestAccAWSRoute53Zone_basic (51.48s) --- PASS: TestAccAWSRoute53Zone_DelegationSetID (56.24s) --- PASS: TestAccAWSRoute53Zone_multiple (57.08s) --- PASS: TestAccAWSRoute53Zone_Comment (63.31s) --- PASS: TestAccAWSRoute53Zone_Tags (79.33s) --- PASS: TestAccAWSRoute53Zone_VPC_Single (99.31s) --- PASS: TestAccAWSRoute53Zone_VPC_Multiple (179.74s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (189.14s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy (189.54s) --- PASS: TestAccAWSRoute53Zone_VPC_Updates (265.16s) ```
The fix for this has been merged and will release with version 2.60.0 of the Terraform AWS Provider, later this week. 👍 |
This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
…eation (hashicorp#12634) Reference: hashicorp#8370 Reference: hashicorp#12361 Reference: hashicorp/terraform#10798 Prevent a crash with non-compliant Route 53 APIs during creation, e.g. LocalStack. This continues best effort support by adding object reference safety, which we should be doing anyways. This change skips synchronization checking rather than raising an error, which seems like the correct and operator friendly behavior in this situation. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSRoute53Zone_disappears (48.02s) --- PASS: TestAccAWSRoute53Zone_basic (51.48s) --- PASS: TestAccAWSRoute53Zone_DelegationSetID (56.24s) --- PASS: TestAccAWSRoute53Zone_multiple (57.08s) --- PASS: TestAccAWSRoute53Zone_Comment (63.31s) --- PASS: TestAccAWSRoute53Zone_Tags (79.33s) --- PASS: TestAccAWSRoute53Zone_VPC_Single (99.31s) --- PASS: TestAccAWSRoute53Zone_VPC_Multiple (179.74s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (189.14s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy (189.54s) --- PASS: TestAccAWSRoute53Zone_VPC_Updates (265.16s) ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Terraform Version
Terraform v0.11.13
Affected Resource(s)
Terraform Configuration Files
Debug Output
Panic Output
https://gist.github.com/meriouma/21604782c76d1dfcf824a0e5270c8802
Expected Behavior
Actual Behavior
Steps to Reproduce
terraform apply
Important Factoids
Using localstack
The text was updated successfully, but these errors were encountered: