Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test import refactor for rds cluster resources #10008

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Acceptance test import refactor for rds cluster resources #10008

merged 1 commit into from
Sep 24, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

NOTE: TestAccAWSRDSCluster_EngineMode, TestAccAWSRDSCluster_s3Restore, TestAccAWSRDSCluster_GlobalClusterIdentifier failures are not new

make testacc TESTARGS="-run=TestAccAWSRDSCluster_"                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRDSCluster_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRDSCluster_basic
=== PAUSE TestAccAWSRDSCluster_basic
=== RUN   TestAccAWSRDSCluster_AvailabilityZones
=== PAUSE TestAccAWSRDSCluster_AvailabilityZones
=== RUN   TestAccAWSRDSCluster_BacktrackWindow
=== PAUSE TestAccAWSRDSCluster_BacktrackWindow
=== RUN   TestAccAWSRDSCluster_ClusterIdentifierPrefix
=== PAUSE TestAccAWSRDSCluster_ClusterIdentifierPrefix
=== RUN   TestAccAWSRDSCluster_DbSubnetGroupName
=== PAUSE TestAccAWSRDSCluster_DbSubnetGroupName
=== RUN   TestAccAWSRDSCluster_s3Restore
=== PAUSE TestAccAWSRDSCluster_s3Restore
=== RUN   TestAccAWSRDSCluster_generatedName
=== PAUSE TestAccAWSRDSCluster_generatedName
=== RUN   TestAccAWSRDSCluster_takeFinalSnapshot
=== PAUSE TestAccAWSRDSCluster_takeFinalSnapshot
=== RUN   TestAccAWSRDSCluster_missingUserNameCausesError
=== PAUSE TestAccAWSRDSCluster_missingUserNameCausesError
=== RUN   TestAccAWSRDSCluster_Tags
=== PAUSE TestAccAWSRDSCluster_Tags
=== RUN   TestAccAWSRDSCluster_EnabledCloudwatchLogsExports
=== PAUSE TestAccAWSRDSCluster_EnabledCloudwatchLogsExports
=== RUN   TestAccAWSRDSCluster_updateIamRoles
=== PAUSE TestAccAWSRDSCluster_updateIamRoles
=== RUN   TestAccAWSRDSCluster_kmsKey
=== PAUSE TestAccAWSRDSCluster_kmsKey
=== RUN   TestAccAWSRDSCluster_encrypted
=== PAUSE TestAccAWSRDSCluster_encrypted
=== RUN   TestAccAWSRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccAWSRDSCluster_copyTagsToSnapshot
=== RUN   TestAccAWSRDSCluster_EncryptedCrossRegionReplication
=== PAUSE TestAccAWSRDSCluster_EncryptedCrossRegionReplication
=== RUN   TestAccAWSRDSCluster_backupsUpdate
=== PAUSE TestAccAWSRDSCluster_backupsUpdate
=== RUN   TestAccAWSRDSCluster_iamAuth
=== PAUSE TestAccAWSRDSCluster_iamAuth
=== RUN   TestAccAWSRDSCluster_DeletionProtection
=== PAUSE TestAccAWSRDSCluster_DeletionProtection
=== RUN   TestAccAWSRDSCluster_EngineMode
=== PAUSE TestAccAWSRDSCluster_EngineMode
=== RUN   TestAccAWSRDSCluster_EngineMode_Global
=== PAUSE TestAccAWSRDSCluster_EngineMode_Global
=== RUN   TestAccAWSRDSCluster_EngineMode_Multimaster
=== PAUSE TestAccAWSRDSCluster_EngineMode_Multimaster
=== RUN   TestAccAWSRDSCluster_EngineMode_ParallelQuery
=== PAUSE TestAccAWSRDSCluster_EngineMode_ParallelQuery
=== RUN   TestAccAWSRDSCluster_EngineVersion
=== PAUSE TestAccAWSRDSCluster_EngineVersion
=== RUN   TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
=== PAUSE TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccAWSRDSCluster_Port
=== PAUSE TestAccAWSRDSCluster_Port
=== RUN   TestAccAWSRDSCluster_ScalingConfiguration
=== PAUSE TestAccAWSRDSCluster_ScalingConfiguration
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
    resource_aws_rds_cluster_test.go:1487: serverless does not support snapshot restore on an empty volume
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== CONT  TestAccAWSRDSCluster_basic
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== CONT  TestAccAWSRDSCluster_iamAuth
=== CONT  TestAccAWSRDSCluster_updateIamRoles
=== CONT  TestAccAWSRDSCluster_kmsKey
=== CONT  TestAccAWSRDSCluster_EnabledCloudwatchLogsExports
=== CONT  TestAccAWSRDSCluster_EngineVersion
=== CONT  TestAccAWSRDSCluster_Tags
=== CONT  TestAccAWSRDSCluster_EngineMode_ParallelQuery
=== CONT  TestAccAWSRDSCluster_missingUserNameCausesError
=== CONT  TestAccAWSRDSCluster_backupsUpdate
=== CONT  TestAccAWSRDSCluster_EncryptedCrossRegionReplication
=== CONT  TestAccAWSRDSCluster_copyTagsToSnapshot
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== CONT  TestAccAWSRDSCluster_encrypted
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== CONT  TestAccAWSRDSCluster_takeFinalSnapshot
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== CONT  TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (9.63s)
=== CONT  TestAccAWSRDSCluster_DbSubnetGroupName
--- PASS: TestAccAWSRDSCluster_iamAuth (125.81s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
--- PASS: TestAccAWSRDSCluster_encrypted (126.23s)
=== CONT  TestAccAWSRDSCluster_generatedName
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (137.74s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
--- PASS: TestAccAWSRDSCluster_EngineVersion (145.81s)
=== CONT  TestAccAWSRDSCluster_s3Restore
--- PASS: TestAccAWSRDSCluster_basic (167.73s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (169.15s)
=== CONT  TestAccAWSRDSCluster_ClusterIdentifierPrefix
--- PASS: TestAccAWSRDSCluster_backupsUpdate (187.90s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (188.13s)
=== CONT  TestAccAWSRDSCluster_BacktrackWindow
--- PASS: TestAccAWSRDSCluster_updateIamRoles (212.95s)
=== CONT  TestAccAWSRDSCluster_AvailabilityZones
--- PASS: TestAccAWSRDSCluster_kmsKey (219.72s)
=== CONT  TestAccAWSRDSCluster_EngineMode_Global
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (226.01s)
=== CONT  TestAccAWSRDSCluster_ScalingConfiguration
--- PASS: TestAccAWSRDSCluster_Tags (230.99s)
=== CONT  TestAccAWSRDSCluster_EngineMode_Multimaster
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (135.16s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
--- PASS: TestAccAWSRDSCluster_generatedName (211.08s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (127.64s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_Add
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (348.03s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (128.39s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (174.68s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (373.67s)
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (387.11s)
=== CONT  TestAccAWSRDSCluster_Port
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (388.24s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_Update
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (157.26s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (406.24s)
=== CONT  TestAccAWSRDSCluster_EngineMode
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (461.04s)
=== CONT  TestAccAWSRDSCluster_DeletionProtection
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (356.82s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (365.10s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (397.45s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (327.87s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (398.50s)
--- PASS: TestAccAWSRDSCluster_Port (260.75s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (197.22s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (379.51s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (354.42s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (386.52s)
--- FAIL: TestAccAWSRDSCluster_EngineMode (343.51s)
    testing.go:569: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        ...
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (419.81s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (412.31s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1150.84s)
--- FAIL: TestAccAWSRDSCluster_s3Restore (1457.87s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: Error waiting for RDS Cluster state to be "available": unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test823076002/main.tf line 72:
          (source code not available)
        
        
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1642.29s)
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier (2320.03s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: error creating RDS Global Cluster: InternalFailure: An internal error has occurred. Please try your query again at a later time.
                status code: 500, request id: 92e21452-88b4-48a1-83ba-9f0d0ca306a5
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test510079212/main.tf line 2:
          (source code not available)
        
        
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (2554.67s)
    testing.go:562: Step 2, expected error:
        
        errors during apply: error creating RDS Global Cluster: InternalFailure: An internal error has occurred. Please try your query again at a later time.
                status code: 500, request id: a4bb77da-283d-4147-b0b5-f1d60e8db2c3
        
        To match:
        
        Existing RDS Clusters cannot be added to an existing RDS Global Cluster
        
        
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (2600.94s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: error creating RDS Global Cluster: InternalFailure: An internal error has occurred. Please try your query again at a later time.
                status code: 500, request id: f8d3b4e9-b83a-4f24-a439-18a3d6142f25
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test005863526/main.tf line 2:
          (source code not available)
        
        
        
        Error: error creating RDS Global Cluster: InternalFailure: An internal error has occurred. Please try your query again at a later time.
                status code: 500, request id: d7f6d768-a7a3-4b6a-bc4e-8e85d7d124a2
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test005863526/main.tf line 2:
          (source code not available)
        
        
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (2672.95s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: error creating RDS Global Cluster: InternalFailure: An internal error has occurred. Please try your query again at a later time.
                status code: 500, request id: 59cd3f19-e765-4e8a-bf86-3ec5d391fe10
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test833822861/main.tf line 2:
          (source code not available)
        
        
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       3062.089s
make: *** [testacc] Error 1

make testacc TESTARGS="-run=TestAccAWSDBClusterParameterGroup"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDBClusterParameterGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDBClusterParameterGroup_basic
=== RUN   TestAccAWSDBClusterParameterGroup_withApplyMethod
=== PAUSE TestAccAWSDBClusterParameterGroup_withApplyMethod
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== PAUSE TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName_Parameter
=== PAUSE TestAccAWSDBClusterParameterGroup_generatedName_Parameter
=== RUN   TestAccAWSDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDBClusterParameterGroup_only
=== PAUSE TestAccAWSDBClusterParameterGroup_only
=== CONT  TestAccAWSDBClusterParameterGroup_basic
=== CONT  TestAccAWSDBClusterParameterGroup_only
=== CONT  TestAccAWSDBClusterParameterGroup_withApplyMethod
=== CONT  TestAccAWSDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== CONT  TestAccAWSDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDBClusterParameterGroup_generatedName_Parameter
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (24.23s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (32.67s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (32.70s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (32.70s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (33.54s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (33.60s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (33.93s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (56.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       57.644s

@ryndaniels ryndaniels requested review from bflad and a team September 5, 2019 14:00
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 5, 2019
@bflad bflad self-assigned this Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
bflad
bflad approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

(Test failures unrelated)

--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (645.95s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (660.78s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (680.94s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (684.04s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (689.93s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (8.27s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (13.51s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (694.67s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (695.58s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (696.31s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (8.12s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (8.00s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (701.11s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (701.14s)
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (6.74s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (8.42s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (9.64s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (9.39s)
--- PASS: TestAccAWSRDSClusterInstance_az (712.22s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.23s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (737.61s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (757.48s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (758.75s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (100.88s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (100.32s)
--- PASS: TestAccAWSRDSCluster_generatedName (109.65s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (113.90s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (817.43s)
--- PASS: TestAccAWSRDSCluster_basic (119.50s)
--- PASS: TestAccAWSRDSCluster_Tags (119.21s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (135.48s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (844.98s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (159.76s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (127.85s)
--- PASS: TestAccAWSRDSCluster_kmsKey (138.70s)
--- PASS: TestAccAWSRDSCluster_encrypted (119.41s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (922.98s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (129.69s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (123.77s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (155.52s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (155.09s)
--- PASS: TestAccAWSRDSCluster_iamAuth (160.10s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (189.71s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (129.33s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (121.77s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (316.50s)
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
--- FAIL: TestAccAWSRDSCluster_EngineMode (289.51s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1149.68s)
--- PASS: TestAccAWSRDSCluster_Port (236.01s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (645.81s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (639.17s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (328.28s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (357.55s)
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1342.37s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (347.42s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1395.45s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (418.06s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (387.50s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (346.91s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (513.35s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (468.14s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (356.98s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (457.87s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (409.16s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (408.00s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (468.09s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (428.62s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (518.07s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1114.14s)
--- FAIL: TestAccAWSRDSCluster_s3Restore (1529.83s)
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1537.95s)
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier (2906.92s)
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (2907.15s)
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (3290.48s)
--- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (3492.96s)

@bflad bflad merged commit 90f6509 into master Sep 24, 2019
@bflad bflad deleted the rfd-at002-rds branch September 24, 2019 10:15
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad