Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Ensure hashibot performs issue labeling with backup, docdb, forecast, personalize, qldb, quicksight, and worklink services #10399

Merged
merged 1 commit into from
Oct 9, 2019
Merged

provider: Ensure hashibot performs issue labeling with backup, docdb, forecast, personalize, qldb, quicksight, and worklink services #10399

merged 1 commit into from
Oct 9, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10392

Release note for CHANGELOG:

NONE

Some of these were likely missed because they live in the GitHub Actions pull request labeling instead of hashibot (where the original list of copy-pasted from), but others are just newer GA services.

Output from acceptance testing: N/A

@bflad
provider: Ensure hashibot performs issue labeling with backup, docdb,…
61a31b2 
… forecast, personalize, qldb, quicksight, and worklink services

Reference: #10392

Some of these were likely missed because they live in the GitHub Actions pull request labeling instead of hashibot (where the original list of copy-pasted from), but others are just newer GA services.
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 6, 2019
@bflad bflad requested a review from a team October 6, 2019 18:41
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 6, 2019
bflad added a commit that referenced this pull request Oct 6, 2019
@bflad
docs/provider: Add .hashibot.hcl changes to New Service checklist
5b45e14 
Reference: #10399
@bflad bflad mentioned this pull request Oct 6, 2019
Merged
@bflad
Copy link
Contributor Author

bflad commented Oct 6, 2019

Regarding the following:

others are just newer GA services

Submitted Contributing Guide documentation update here: #10400

@ewbankkit
Copy link
Contributor

@bflad RE this comment from @aeschright, it looks like if the comprehend service is added to .hashibot.hcl then .github/PULL_REQUEST_LABELS.yml can be removed.
GitHub actions have continually had errors on forks.

aeschright
aeschright approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad
Copy link
Contributor Author

bflad commented Oct 9, 2019

@ewbankkit thanks! I think we're probably going to remove our GitHub Actions labeling experiment due to the forking issue. Long live, @hashibot!

@aeschright oh! Just so you're aware, these .hashibot.hcl changes were added to the Contributing Guide via #10400

@bflad bflad merged commit 7dabcf7 into master Oct 9, 2019
@bflad bflad deleted the td-hashibot-issue-label-sync branch October 9, 2019 18:57
@bflad bflad added this to the v2.32.0 milestone Oct 9, 2019
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @ewbankkit @aeschright