Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_subnet: Refactor to use keyvaluetags library and call Read after Create #10411

Merged
merged 1 commit into from
Oct 25, 2019

Commits on Oct 7, 2019

  1. resource/aws_subnet: Refactor to use keyvaluetags library and call Re…

    …ad after Create
    
    Reference: #7926
    Similar in nature to: #10315
    
    In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create.
    
    Ouput from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s)
    --- PASS: TestAccAWSSubnet_basic (25.66s)
    --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s)
    --- PASS: TestAccAWSSubnet_ipv6 (66.62s)
    ```
    bflad committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    8b460a8 View commit details
    Browse the repository at this point in the history