Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reader_endpoint_address attribute for aws_elasticache_replication_group resource #10531

Closed
wants to merge 2 commits into from
Closed

Add reader_endpoint_address attribute for aws_elasticache_replication_group resource #10531

wants to merge 2 commits into from

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10519

Release note for CHANGELOG:

r/aws_elasticache_replication_group: add `reader_endpoint_address` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== CONT  TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1085.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1085.230s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.012s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.036s [no tests to run]

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== PAUSE TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== CONT  TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (945.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	945.239s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.009s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.128s [no tests to run]

@teraken0509 teraken0509 requested a review from a team October 17, 2019 08:30
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 17, 2019
@teraken0509 teraken0509 force-pushed the feature/add-reader_endpoint_address-attribute-for-aws_elasticache_replication_group-resource branch from 09a38c1 to ff4402a Compare November 5, 2019 10:52
@teraken0509
Copy link
Contributor Author

Re-run acctest.

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== CONT  TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1074.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1074.247s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.026s [no tests to run]

$  make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== PAUSE TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== CONT  TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (871.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	871.758s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.012s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.024s [no tests to run]

@alberts-s
Copy link

alberts-s commented Dec 5, 2019 •
edited
Loading

Hey @kterada0509, any chance you could also update documentation to provide information about the existence of the reader_endpoint attribute? See the "CONTRIBUTING" checklist.

@teraken0509 teraken0509 force-pushed the feature/add-reader_endpoint_address-attribute-for-aws_elasticache_replication_group-resource branch from ff4402a to f258680 Compare December 6, 2019 03:12
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 6, 2019
@teraken0509
Copy link
Contributor Author

@Alberts00
Thanks, I added attribute for docs.

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 24, 2020
@alexjurkiewicz alexjurkiewicz mentioned this pull request Nov 6, 2020
Closed
@gdavison
Copy link
Contributor

gdavison commented Jan 5, 2021

Thanks for the PR, @teraken0509. We've merged #9979, which also supports the data source

@gdavison gdavison closed this Jan 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader endpoint in aws_elasticache_replication_group
4 participants
@teraken0509 @alberts-s @gdavison @anGie44