Update normalize function to put in state file full certificate data instead of hashes

[rdublenych]

The current behaviour of the resource is to put a hash of certificate data (private key, certificate body, chain code) in the state file.
It causes an error because the provider sends these hashes of unmodified fields instead of source data on resource update.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10847.
Also, may fix #9809.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
go test ./... -timeout=30s -parallel=4
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws       18.835s
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags (cached)
...

Test cases:

Update imported certificate

1. import new certificate by using acm_certificate resource
2. update certificate_body field
3. update imported certificate

current version

Error: Error updating certificate: ValidationException: com.amazonaws.pki.acm.exceptions.external.ValidationException: Could not validate the certificate with the certificate chain.

result: imported certificate was not updated.

fixed version (pr)

Apply complete

result: imported certificate was updated successfully.

[julienduchesne]

This was already fixed here: #9685
With a new test

[bflad]

Hi @rdublenych 👋 Thank you for submitting this. As @julienduchesne mentions above, there was a previous contribution covering the intention of this pull request, at least with the aws_acm_certificate resource, which has been reviewed and merged. We intend to apply similar resource-level changes to cover the aws_iam_server_certificate resource without modifying these two functions as it will allow us to determine if the update can occur without calling the API. Thanks again for the contribution and if there are lingering issues after version 3.0.0 is released, please let us know.

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!