Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/wafv2: Initial service client and tagging implementation #11172

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #11046

Release note for CHANGELOG:

NONE

Following the Contributing Guide.

Output from acceptance testing:

--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.08s)
--- PASS: TestAccAWSProvider_Endpoints (3.10s)

Reference: #11046

Following the [Contributing Guide](https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service).

Output from acceptance testing:

```
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.08s)
--- PASS: TestAccAWSProvider_Endpoints (3.10s)
```
@bflad bflad added the service/wafv2 Issues and PRs that pertain to the wafv2 service. label Dec 6, 2019
@bflad bflad requested a review from a team December 6, 2019 14:38
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 6, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

--- PASS: TestAccAWSProvider_Endpoints_Deprecated (8.23s)
--- PASS: TestAccAWSProvider_Endpoints (10.30s)

@bflad bflad added this to the v2.44.0 milestone Dec 20, 2019
@bflad bflad merged commit 8faee6c into master Dec 20, 2019
@bflad bflad deleted the f-wafv2-client branch December 20, 2019 02:44
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants