Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] aws_vpn_connection: fix possible remote state data inconsistency #11297

Closed
wants to merge 2 commits into from
Closed

[WIP] aws_vpn_connection: fix possible remote state data inconsistency #11297

wants to merge 2 commits into from

Conversation

n3ph
Copy link
Contributor

@n3ph n3ph commented Dec 14, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11293

Release note for CHANGELOG:

aws_vpn_connection: fix possible remote state data inconsistency 

Output from acceptance testing:

After substantiated test case (c65aa11):

make testacc TEST=./aws TESTARGS='-run=TestAWSVpnConnection_xmlconfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAWSVpnConnection_xmlconfig -timeout 120m
=== RUN   TestAWSVpnConnection_xmlconfig
--- FAIL: TestAWSVpnConnection_xmlconfig (0.00s)
    resource_aws_vpn_connection_test.go:397: First address from tunnel XML was incorrect.
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	0.019s
FAIL
make: *** [GNUmakefile:24: testacc] Error 1

@n3ph n3ph requested a review from a team December 14, 2019 22:46
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 14, 2019
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 14, 2019
@n3ph n3ph closed this Dec 14, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_vpn_connection: inconsistent remote state data (occasionally)
2 participants