Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Enable tfproviderlint R004 check #11499

Merged
merged 2 commits into from
Feb 5, 2020
Merged

tests/provider: Enable tfproviderlint R004 check #11499

merged 2 commits into from
Feb 5, 2020

Commits on Feb 5, 2020

  1. tests/provider: Enable tfproviderlint R004 check 

    Reference: https://github.com/bflad/tfproviderlint/blob/master/passes/R004/README.md
Reference: #9954
    @bflad
    bflad committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    75de0eb View commit details
    Browse the repository at this point in the history

  2. resource/aws_s3_bucket: Fix complex import of aws_s3_bucket_policy to… 

    … properly set policy in state

Found via linting:

```
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/import_aws_s3_bucket.go:36:22: R004: ResourceData.Set() incompatible value type: *github.com/aws/aws-sdk-go/service/s3.GetBucketPolicyOutput
35		pData.Set("bucket", d.Id())
36		pData.Set("policy", pol)
37		results = append(results, pData)
```

This type of complex import (importing multiple resources) is likely to be removed in a future major version.

Output from relevant acceptance testing (other tests do not perform necessary ImportStateCheck to verify complex import):

```
--- PASS: TestAccAWSS3Bucket_Policy (95.74s)
```
    @bflad
    bflad committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    f417c82 View commit details
    Browse the repository at this point in the history