Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parquet cost report format #11567

Closed
wants to merge 1 commit into from
Closed

Add Parquet cost report format #11567

wants to merge 1 commit into from

Conversation

lurcio
Copy link
Contributor

@lurcio lurcio commented Jan 12, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8765

Release note for CHANGELOG:

resource/aws_cur_report_definition: Add `Parquet` as compression and report format

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsCurReportDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAwsCurReportDefinition -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsCurReportDefinition_athena
=== PAUSE TestAccAwsCurReportDefinition_athena
=== RUN   TestAccAwsCurReportDefinition_redshift_quicksight
=== PAUSE TestAccAwsCurReportDefinition_redshift_quicksight
=== CONT  TestAccAwsCurReportDefinition_athena
=== CONT  TestAccAwsCurReportDefinition_redshift_quicksight
--- PASS: TestAccAwsCurReportDefinition_athena (38.57s)
--- PASS: TestAccAwsCurReportDefinition_redshift_quicksight (39.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.966s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.007s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.017s [no tests to run]

@lurcio lurcio requested a review from a team January 12, 2020 00:50
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 12, 2020
@jason-riddle jason-riddle mentioned this pull request Jan 15, 2020
Closed
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/costandusagereportservice and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2020
@lurcio lurcio changed the title Initial commit Add Parquet cost report format Jan 17, 2020
@rverma-jm
Copy link

Can we please get this merged?

bflad added a commit that referenced this pull request Mar 4, 2020
@bflad
provider: Additional hashibot pull request labeling
a49012a 
Reference: #11567 (missing aws_cur_report service label)
Reference: #12103 (missing aws_snapshot_create_volume_permission service label)
Reference: #12020 / #12224 (missing aws_subnet_ids service label)
@bflad bflad mentioned this pull request Mar 4, 2020
Merged
bflad added a commit that referenced this pull request Mar 10, 2020
@bflad
provider: Additional hashibot pull request labeling (#12241)
4f26bb3 
Reference: #11567 (missing aws_cur_report service label)
Reference: #12103 (missing aws_snapshot_create_volume_permission service label)
Reference: #12020 / #12224 (missing aws_subnet_ids service label)
@robbruce robbruce mentioned this pull request Mar 17, 2020
Merged
Base automatically changed from master to main January 23, 2021 00:56
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:56
@ewbankkit
Copy link
Contributor

@lurcio Thanks for the contribution.
This has been implemented in #12428, released with v3.5.0 of the AWS Provider.

@ewbankkit ewbankkit closed this Jan 29, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_cur_report_definition doesn't support Parquet
4 participants
@lurcio @rverma-jm @ewbankkit @bflad