Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor S3 Bucket resource to use keyvaluetags package #11916

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Refactor S3 Bucket resource to use keyvaluetags package #11916

merged 5 commits into from
Feb 10, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 5, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSS3Bucket_ -timeout 120m
=== RUN   TestAccAWSS3Bucket_basic
=== PAUSE TestAccAWSS3Bucket_basic
=== RUN   TestAccAWSS3Bucket_Bucket_EmptyString
=== PAUSE TestAccAWSS3Bucket_Bucket_EmptyString
=== RUN   TestAccAWSS3Bucket_tagsWithNoSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithNoSystemTags
=== RUN   TestAccAWSS3Bucket_tagsWithSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithSystemTags
=== RUN   TestAccAWSS3Bucket_namePrefix
=== PAUSE TestAccAWSS3Bucket_namePrefix
=== RUN   TestAccAWSS3Bucket_generatedName
=== PAUSE TestAccAWSS3Bucket_generatedName
=== RUN   TestAccAWSS3Bucket_region
=== PAUSE TestAccAWSS3Bucket_region
=== RUN   TestAccAWSS3Bucket_acceleration
=== PAUSE TestAccAWSS3Bucket_acceleration
=== RUN   TestAccAWSS3Bucket_RequestPayer
=== PAUSE TestAccAWSS3Bucket_RequestPayer
=== RUN   TestAccAWSS3Bucket_Policy
=== PAUSE TestAccAWSS3Bucket_Policy
=== RUN   TestAccAWSS3Bucket_UpdateAcl
=== PAUSE TestAccAWSS3Bucket_UpdateAcl
=== RUN   TestAccAWSS3Bucket_Website_Simple
=== PAUSE TestAccAWSS3Bucket_Website_Simple
=== RUN   TestAccAWSS3Bucket_WebsiteRedirect
=== PAUSE TestAccAWSS3Bucket_WebsiteRedirect
=== RUN   TestAccAWSS3Bucket_WebsiteRoutingRules
=== PAUSE TestAccAWSS3Bucket_WebsiteRoutingRules
=== RUN   TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== RUN   TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== RUN   TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== PAUSE TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== RUN   TestAccAWSS3Bucket_shouldFailNotFound
=== PAUSE TestAccAWSS3Bucket_shouldFailNotFound
=== RUN   TestAccAWSS3Bucket_Versioning
=== PAUSE TestAccAWSS3Bucket_Versioning
=== RUN   TestAccAWSS3Bucket_Cors_Update
=== PAUSE TestAccAWSS3Bucket_Cors_Update
=== RUN   TestAccAWSS3Bucket_Cors_Delete
=== PAUSE TestAccAWSS3Bucket_Cors_Delete
=== RUN   TestAccAWSS3Bucket_Cors_EmptyOrigin
=== PAUSE TestAccAWSS3Bucket_Cors_EmptyOrigin
=== RUN   TestAccAWSS3Bucket_Logging
=== PAUSE TestAccAWSS3Bucket_Logging
=== RUN   TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== RUN   TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== PAUSE TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== RUN   TestAccAWSS3Bucket_Replication
=== PAUSE TestAccAWSS3Bucket_Replication
=== RUN   TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
=== PAUSE TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
=== RUN   TestAccAWSS3Bucket_ReplicationWithoutStorageClass
=== PAUSE TestAccAWSS3Bucket_ReplicationWithoutStorageClass
=== RUN   TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== PAUSE TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== RUN   TestAccAWSS3Bucket_ReplicationWithoutPrefix
=== PAUSE TestAccAWSS3Bucket_ReplicationWithoutPrefix
=== RUN   TestAccAWSS3Bucket_ReplicationSchemaV2
=== PAUSE TestAccAWSS3Bucket_ReplicationSchemaV2
=== RUN   TestAccAWSS3Bucket_objectLock
=== PAUSE TestAccAWSS3Bucket_objectLock
=== RUN   TestAccAWSS3Bucket_forceDestroy
=== PAUSE TestAccAWSS3Bucket_forceDestroy
=== RUN   TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
=== RUN   TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
=== CONT  TestAccAWSS3Bucket_basic
=== CONT  TestAccAWSS3Bucket_Versioning
--- PASS: TestAccAWSS3Bucket_basic (42.66s)
=== CONT  TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (41.42s)
=== CONT  TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
--- PASS: TestAccAWSS3Bucket_Versioning (101.43s)
=== CONT  TestAccAWSS3Bucket_forceDestroy
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (38.02s)
=== CONT  TestAccAWSS3Bucket_objectLock
--- PASS: TestAccAWSS3Bucket_forceDestroy (38.09s)
=== CONT  TestAccAWSS3Bucket_ReplicationSchemaV2
--- PASS: TestAccAWSS3Bucket_objectLock (72.24s)
=== CONT  TestAccAWSS3Bucket_ReplicationWithoutPrefix
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (84.14s)
=== CONT  TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (41.94s)
=== CONT  TestAccAWSS3Bucket_ReplicationWithoutStorageClass
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (252.85s)
=== CONT  TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (84.58s)
=== CONT  TestAccAWSS3Bucket_Replication
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (168.49s)
=== CONT  TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (72.19s)
=== CONT  TestAccAWSS3Bucket_LifecycleBasic
--- PASS: TestAccAWSS3Bucket_Replication (262.74s)
=== CONT  TestAccAWSS3Bucket_Logging
--- PASS: TestAccAWSS3Bucket_Logging (59.90s)
=== CONT  TestAccAWSS3Bucket_Cors_EmptyOrigin
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (101.20s)
=== CONT  TestAccAWSS3Bucket_Cors_Delete
--- PASS: TestAccAWSS3Bucket_Cors_Delete (35.92s)
=== CONT  TestAccAWSS3Bucket_Cors_Update
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (42.94s)
=== CONT  TestAccAWSS3Bucket_Policy
--- PASS: TestAccAWSS3Bucket_Cors_Update (73.53s)
=== CONT  TestAccAWSS3Bucket_shouldFailNotFound
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (22.16s)
=== CONT  TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
--- PASS: TestAccAWSS3Bucket_Policy (97.61s)
=== CONT  TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (42.29s)
=== CONT  TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (71.02s)
=== CONT  TestAccAWSS3Bucket_WebsiteRoutingRules
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (71.13s)
=== CONT  TestAccAWSS3Bucket_WebsiteRedirect
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (73.91s)
=== CONT  TestAccAWSS3Bucket_Website_Simple
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (104.91s)
=== CONT  TestAccAWSS3Bucket_UpdateAcl
--- PASS: TestAccAWSS3Bucket_Website_Simple (101.95s)
=== CONT  TestAccAWSS3Bucket_generatedName
--- PASS: TestAccAWSS3Bucket_generatedName (41.60s)
=== CONT  TestAccAWSS3Bucket_RequestPayer
--- PASS: TestAccAWSS3Bucket_UpdateAcl (70.20s)
=== CONT  TestAccAWSS3Bucket_acceleration
--- PASS: TestAccAWSS3Bucket_RequestPayer (71.51s)
=== CONT  TestAccAWSS3Bucket_region
--- PASS: TestAccAWSS3Bucket_acceleration (73.49s)
=== CONT  TestAccAWSS3Bucket_tagsWithSystemTags
--- PASS: TestAccAWSS3Bucket_region (40.50s)
=== CONT  TestAccAWSS3Bucket_namePrefix
--- PASS: TestAccAWSS3Bucket_namePrefix (41.18s)
=== CONT  TestAccAWSS3Bucket_tagsWithNoSystemTags
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (179.88s)
=== CONT  TestAccAWSS3Bucket_Bucket_EmptyString
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (130.40s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (42.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1452.765s

@ewbankkit ewbankkit requested a review from a team February 5, 2020 21:27
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 5, 2020
Kit Ewbank and others added 2 commits February 7, 2020 09:03
@ewbankkit
r/aws_s3_bucket_object: Refactor to use keyvaluetags package.
5459f92
@ewbankkit
Replace 'tagsMapToHash' with 'KeyValueTags.Hash' method.
e475f6b 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_ReplicationSchemaV2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_ReplicationSchemaV2 -timeout 120m
=== RUN   TestAccAWSS3Bucket_ReplicationSchemaV2
=== PAUSE TestAccAWSS3Bucket_ReplicationSchemaV2
=== CONT  TestAccAWSS3Bucket_ReplicationSchemaV2
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (255.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	255.337s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupPlan_withRecoveryPointTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_withRecoveryPointTags -timeout 120m
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (62.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.964s
@ghost ghost added the service/backup Issues and PRs that pertain to the backup service. label Feb 7, 2020
@ewbankkit ewbankkit changed the title [WIP] Refactor S3 Bucket resource to use keyvaluetags package [WIP] Refactor S3 Bucket and Object resources to use keyvaluetags package Feb 7, 2020
@ewbankkit ewbankkit changed the title [WIP] Refactor S3 Bucket and Object resources to use keyvaluetags package Refactor S3 Bucket resource to use keyvaluetags package Feb 7, 2020
@gdavison gdavison self-assigned this Feb 7, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Feb 7, 2020
gdavison
gdavison approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSS3Bucket_basic (22.58s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (23.21s)
--- PASS: TestAccAWSS3Bucket_namePrefix (22.12s)
--- PASS: TestAccAWSS3Bucket_generatedName (22.05s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (17.55s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (35.44s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (21.80s)
--- PASS: TestAccAWSS3Bucket_acceleration (39.56s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (35.52s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (20.65s)
--- PASS: TestAccAWSS3Bucket_region (53.84s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (23.61s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (35.39s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (61.37s)
--- PASS: TestAccAWSS3Bucket_Logging (23.69s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (34.25s)
--- PASS: TestAccAWSS3Bucket_Policy (45.77s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (40.39s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (47.58s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (47.45s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (36.20s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (16.61s)
--- PASS: TestAccAWSS3Bucket_Versioning (43.86s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (16.67s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (16.04s)
--- PASS: TestAccAWSS3Bucket_objectLock (25.99s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (95.23s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (41.08s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (63.91s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (62.34s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (155.10s)
--- PASS: TestAccAWSS3Bucket_Replication (183.22s)

Test run includes some failures on the list of intermittent failures

@gdavison gdavison added this to the v2.49.0 milestone Feb 7, 2020
@gdavison gdavison merged commit 4cb1211 into hashicorp:master Feb 10, 2020
@ewbankkit ewbankkit deleted the s3-keyvaluetags branch February 10, 2020 21:24
@ewbankkit ewbankkit mentioned this pull request Feb 12, 2020
Merged
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@abhinavdahiya abhinavdahiya mentioned this pull request Mar 16, 2020
Merged
abhinavdahiya added a commit to abhinavdahiya/terraform-provider-aws that referenced this pull request Mar 17, 2020
@abhinavdahiya
resource_aws_s3_bucket.go: retry NoSuchBucket when updating tags for …
b51938a 
…s3 bucket

The original retry was added in [1] but, in later refactor the retry was dropped [2]

the causes failures like

```
level=error msg="Error: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
level=error msg="\tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
level=error
level=error msg="  on ../tmp/openshift-install-019032273/bootstrap/main.tf line 7, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg="   7: resource \"aws_s3_bucket\" \"ignition\" {"
level=error
level=error
```

debug error:
```
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: [DEBUG] [aws-sdk-go] DEBUG: Validate Response s3/GetBucketTagging failed, attempt 0/25, error NoSuchBucket: The specified bucket does not exist"
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: \tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
time="2020-03-16T10:45:53Z" level=debug msg="[DEBUG] module.bootstrap.aws_s3_bucket.ignition: apply errored, but we're indicating that via the Error pointer rather than returning it: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
```

[1]: hashicorp#10863
[2]: hashicorp#11916
bflad pushed a commit that referenced this pull request Mar 17, 2020
@abhinavdahiya
resource/aws_s3_bucket: Retry NoSuchBucket error when setting tags du…
a08a75d 
…ring resource creation (#12418)

The original retry was added in [1] but, in later refactor the retry was dropped [2]

the causes failures like

```
level=error msg="Error: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
level=error msg="\tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
level=error
level=error msg="  on ../tmp/openshift-install-019032273/bootstrap/main.tf line 7, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg="   7: resource \"aws_s3_bucket\" \"ignition\" {"
level=error
level=error
```

debug error:
```
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: [DEBUG] [aws-sdk-go] DEBUG: Validate Response s3/GetBucketTagging failed, attempt 0/25, error NoSuchBucket: The specified bucket does not exist"
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: \tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
time="2020-03-16T10:45:53Z" level=debug msg="[DEBUG] module.bootstrap.aws_s3_bucket.ignition: apply errored, but we're indicating that via the Error pointer rather than returning it: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
```

[1]: #10863
[2]: #11916

Output from acceptance testing (failures unrelated):

```
--- FAIL: TestAccAWSS3Bucket_acceleration (10.31s)
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (22.92s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (24.74s)
--- PASS: TestAccAWSS3Bucket_basic (15.90s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (15.78s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (13.81s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (15.40s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (25.35s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (25.34s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (16.30s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (34.44s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (11.94s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (11.09s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (12.85s)
--- PASS: TestAccAWSS3Bucket_generatedName (16.61s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (25.53s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (21.66s)
--- PASS: TestAccAWSS3Bucket_Logging (18.80s)
--- PASS: TestAccAWSS3Bucket_namePrefix (15.44s)
--- PASS: TestAccAWSS3Bucket_objectLock (19.55s)
--- PASS: TestAccAWSS3Bucket_Policy (35.15s)
--- PASS: TestAccAWSS3Bucket_region (14.15s)
--- PASS: TestAccAWSS3Bucket_Replication (130.64s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (87.14s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (26.74s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (108.61s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (40.18s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (41.80s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (26.72s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (10.49s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (45.69s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (80.96s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (23.42s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (34.79s)
--- PASS: TestAccAWSS3Bucket_Versioning (31.30s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (32.40s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (32.73s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (25.14s)
--- PASS: TestAccAWSS3MultiBucket_withTags (17.79s)
```
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
service/backup Issues and PRs that pertain to the backup service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @gdavison