New resource r/aws_wafv2_ip_set

[pvanbuijtene]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11173
Relates #11046

* **New Resource**: `aws_wafv2_ip_set` (#12119)

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAwsWafv2IPSet_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWafv2IPSet_* -timeout 120m
...
--- PASS: TestAccAwsWafv2IPSet_minimal (14.02s)
--- PASS: TestAccAwsWafv2IPSet_changeNameForceNew (24.21s)
--- PASS: TestAccAwsWafv2IPSet_basic (32.15s)
--- PASS: TestAccAwsWafv2IPSet_tags (36.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       36.850s

[pvanbuijtene]

@dessite @DrFaust92 thanks for the review

[anGie44]

hi @pvanbuijtene, thank you for this PR! Looks great overall, just a few comments

[pvanbuijtene]

@anGie44 thanks for the review, the changes are applied.

...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWafv2IPSet -timeout 120m
...
--- PASS: TestAccAwsWafv2IPSet_Disappears (14.87s)
--- PASS: TestAccAwsWafv2IPSet_Minimal (22.19s)
--- PASS: TestAccAwsWafv2IPSet_Basic (35.51s)
--- PASS: TestAccAwsWafv2IPSet_ChangeNameForceNew (37.66s)
--- PASS: TestAccAwsWafv2IPSet_Tags (53.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       54.968s

[pvanbuijtene]

@anGie44 I fixed and added some extra checks, let me know if I missed something.

[anGie44]

Many thanks @pvanbuijtene! one catch in the resource re: pointer conversion and a suggestion to the documentation to match general formatting used around the provider's resource docs

Output of acceptance tests:

--- PASS: TestAccAwsWafv2IPSet_Minimal
--- PASS: TestAccAwsWafv2IPSet_Disappears
--- PASS: TestAccAwsWafv2IPSet_Basic
--- PASS: TestAccAwsWafv2IPSet_ChangeNameForceNew
--- PASS: TestAccAwsWafv2IPSet_Tags
--- PASS: TestAccAwsWafv2IPSet_IPv6

[bflad]

Pre-emptively approving -- great work @pvanbuijtene and @anGie44!

Output from acceptance testing:

--- PASS: TestAccAwsWafv2IPSet_Disappears (18.53s)
--- PASS: TestAccAwsWafv2IPSet_ChangeNameForceNew (23.11s)
--- PASS: TestAccAwsWafv2IPSet_Minimal (24.76s)
--- PASS: TestAccAwsWafv2IPSet_IPv6 (25.26s)
--- PASS: TestAccAwsWafv2IPSet_Basic (28.74s)
--- PASS: TestAccAwsWafv2IPSet_Tags (34.23s)

[anGie44]

Nice, all set @pvanbuijtene ! 🙌

[ghost]

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!