AWS QuickSight keyvaluetags

[leppikallio]

Community Note

keyvaluetags for AWS QuickSight resources.

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #10990, #11834, #11835

Release note for CHANGELOG:

Support for keyvaluetags for AWS QuickSight

Output from acceptance testing:

make testacc TESTARGS='-run=TestKeyValueTagsQuicksightTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestKeyValueTagsQuicksightTags -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.134s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.458s [no tests to run]
=== RUN   TestKeyValueTagsQuicksightTags
=== RUN   TestKeyValueTagsQuicksightTags/empty
=== RUN   TestKeyValueTagsQuicksightTags/non_empty
--- PASS: TestKeyValueTagsQuicksightTags (0.00s)
    --- PASS: TestKeyValueTagsQuicksightTags/empty (0.00s)
    --- PASS: TestKeyValueTagsQuicksightTags/non_empty (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	2.672s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/naming	0.696s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.264s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token	0.304s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes	0.624s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001	1.445s [no tests to run]

make testacc TESTARGS='-run=TestQuicksightKeyValueTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestQuicksightKeyValueTags -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.102s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.545s [no tests to run]
=== RUN   TestQuicksightKeyValueTags
=== RUN   TestQuicksightKeyValueTags/empty
=== RUN   TestQuicksightKeyValueTags/non_empty
--- PASS: TestQuicksightKeyValueTags (0.00s)
    --- PASS: TestQuicksightKeyValueTags/empty (0.00s)
    --- PASS: TestQuicksightKeyValueTags/non_empty (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.581s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/naming	0.434s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.143s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token	0.677s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes	0.594s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001	0.400s [no tests to run]

[bflad]

Looks good, thanks @leppikallio 🚀

[ghost]

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!