Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/subnet - Fix removing ipv6 cidr block from subnet #12303

Merged
merged 15 commits into from
Aug 20, 2020
Merged

r/subnet - Fix removing ipv6 cidr block from subnet #12303

merged 15 commits into from
Aug 20, 2020

Commits on Aug 19, 2020

  1. fix removing ipv6 cidr block 

    add plan time validation to cidr blocks
use enums
remove partial when updating
refactor errors
    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4b0e9fa View commit details
    Browse the repository at this point in the history

  2. fix removing ipv6 cidr block

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    43fe559 View commit details
    Browse the repository at this point in the history

  3. add more test cases

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7b57c43 View commit details
    Browse the repository at this point in the history

  4. add disappears test case

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    27e3618 View commit details
    Browse the repository at this point in the history

  5. indentation

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c505920 View commit details
    Browse the repository at this point in the history

  6. change cidr validations to specific ones 

    use sdk wrappers
use %w for errors
use common disappears function
make az_id test region agnostic
    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    cd798ba View commit details
    Browse the repository at this point in the history

  7. fix az id test

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f756ff7 View commit details
    Browse the repository at this point in the history

  8. review comments

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    38f2bb7 View commit details
    Browse the repository at this point in the history

  9. lint

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f3558e2 View commit details
    Browse the repository at this point in the history

  10. log disappearing subnet

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a63140b View commit details
    Browse the repository at this point in the history

  11. test

    @DrFaust92
    DrFaust92 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8a36e15 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Update aws/resource_aws_subnet_test.go 

    Co-authored-by: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9ee579e View commit details
    Browse the repository at this point in the history

  2. Update aws/resource_aws_subnet_test.go 

    Co-authored-by: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    d90cb64 View commit details
    Browse the repository at this point in the history

  3. az id

    @DrFaust92
    DrFaust92 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    aab1897 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @bflad
    bflad authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7a877f3 View commit details
    Browse the repository at this point in the history