Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for route53 zone schema #12340

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

FrancisLfg
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12238

Release note for CHANGELOG:

NONE

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute53Zone_
=== RUN   TestAccAWSRoute53Zone_basic
=== PAUSE TestAccAWSRoute53Zone_basic
=== RUN   TestAccAWSRoute53Zone_disappears
=== PAUSE TestAccAWSRoute53Zone_disappears
=== RUN   TestAccAWSRoute53Zone_multiple
=== PAUSE TestAccAWSRoute53Zone_multiple
=== RUN   TestAccAWSRoute53Zone_Comment
=== PAUSE TestAccAWSRoute53Zone_Comment
=== RUN   TestAccAWSRoute53Zone_DelegationSetID
=== PAUSE TestAccAWSRoute53Zone_DelegationSetID
=== RUN   TestAccAWSRoute53Zone_ForceDestroy
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy
=== RUN   TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== RUN   TestAccAWSRoute53Zone_Tags
=== PAUSE TestAccAWSRoute53Zone_Tags
=== RUN   TestAccAWSRoute53Zone_VPC_Single
=== PAUSE TestAccAWSRoute53Zone_VPC_Single
=== RUN   TestAccAWSRoute53Zone_VPC_Multiple
=== PAUSE TestAccAWSRoute53Zone_VPC_Multiple
=== RUN   TestAccAWSRoute53Zone_VPC_Updates
=== PAUSE TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53Zone_basic
=== CONT  TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== CONT  TestAccAWSRoute53Zone_ForceDestroy
=== CONT  TestAccAWSRoute53Zone_disappears
=== CONT  TestAccAWSRoute53Zone_Comment
=== CONT  TestAccAWSRoute53Zone_multiple
=== CONT  TestAccAWSRoute53Zone_VPC_Multiple
=== CONT  TestAccAWSRoute53Zone_DelegationSetID
=== CONT  TestAccAWSRoute53Zone_VPC_Single
=== CONT  TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53Zone_Tags
--- PASS: TestAccAWSRoute53Zone_disappears (59.37s)
--- PASS: TestAccAWSRoute53Zone_basic (69.77s)
--- PASS: TestAccAWSRoute53Zone_multiple (70.13s)
--- PASS: TestAccAWSRoute53Zone_Comment (90.52s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (91.78s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (105.28s)
--- PASS: TestAccAWSRoute53Zone_Tags (113.14s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (179.29s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (221.17s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (229.37s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (286.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       286.793s
...

@FrancisLfg FrancisLfg requested a review from a team March 10, 2020 21:11
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. labels Mar 10, 2020
@bflad bflad requested a review from a team as a code owner January 6, 2021 18:09
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2021
@bflad bflad self-assigned this Jan 6, 2021
@bflad bflad added this to the v3.23.0 milestone Jan 6, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @FrancisLfg 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRoute53Zone_basic (68.77s)
--- PASS: TestAccAWSRoute53Zone_Comment (81.81s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (70.15s)
--- PASS: TestAccAWSRoute53Zone_disappears (60.90s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (189.58s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (189.64s)
--- PASS: TestAccAWSRoute53Zone_multiple (68.79s)
--- PASS: TestAccAWSRoute53Zone_Tags (114.64s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (182.20s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (111.32s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (233.79s)

--- PASS: TestAccAWSRoute53ZoneDataSource_id (79.59s)
--- PASS: TestAccAWSRoute53ZoneDataSource_name (70.23s)
--- PASS: TestAccAWSRoute53ZoneDataSource_serviceDiscovery (124.80s)
--- PASS: TestAccAWSRoute53ZoneDataSource_tags (119.05s)
--- PASS: TestAccAWSRoute53ZoneDataSource_vpc (133.88s)

@bflad bflad merged commit 948f5e1 into hashicorp:master Jan 6, 2021
bflad added a commit that referenced this pull request Jan 6, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R53 Delegation Set: Member must have length less than or equal to 32
2 participants