New data source: aws_spot_price_history

[janschumann]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Motivation

Currently we configure spot prices as terraform variables. In some cases these prices vary frequently, so that somebody has to lookup the prices in AWS and update the code accordingly.

Please consider the following example, which uses the new resource in conjunction with a launch configuration. If an instance, cannot start due to a higher spot price, just apply the corresponding terraform workspace.

# Request spot prices
resource "aws_spot_price_history" "prices" {
  start_time = "2020-04-13T01:10:30Z"
  filter {
    name = "instance_type"
    values = ["m4.large"]
  } 
}

# use the latest price for the launch configuration
resource "aws_launch_configuration" "default" {
  name          = "default"
  image_id      = "${data.aws_ami.ubuntu.id}"
  instance_type = "m4.large"
  spot_price    = data.aws_spot_price_history.prices.latest.spot_price * 1.2
}

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotPriceHistoryDataSource_instance_type_filter'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSpotPriceHistoryDataSource_instance_type -timeout 120m
=== RUN   TestAccAWSSpotPriceHistoryDataSource_instance_type_filter
=== PAUSE TestAccAWSSpotPriceHistoryDataSource_instance_type_filter
=== CONT  TestAccAWSSpotPriceHistoryDataSource_instance_type_filter
--- PASS: TestAccAWSSpotPriceHistoryDataSource_instance_type_filter (40.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.407s

[ewbankkit]

Similar:

• d/aws_ec2_instance_spot_price - add new data source #12504

[bflad]

Hi @janschumann 👋 Thank you for submitting this! As @ewbankkit mentions above, it appears there is an earlier contribution for this functionality with #12504. In these situations the maintainers will review contributions in their submission order and you're welcome to provide your feedback there as well.

[bflad]

Just to followup, #12504 has been reviewed and will be merged shortly after we release 3.0. Thanks again for contributing this, @janschumann. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!