Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpc_peering_accepter correct comment syntax #1387

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

heathsnow
Copy link
Contributor

@heathsnow heathsnow commented Aug 10, 2017

Website syntax highlighting is wrong because of incorrect comment syntax.

  • incorrect comment syntax: //
  • correct comment syntax: #

Website syntax highlighting is wrong because of incorrect comment tags.
- old tag `//`
- new tag `#`
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support both formats, so this does no harm, but # does seem to be majority in AWS provider, so I'll be happy to accept PR for changing the other outlier too 😉

grep -R '// ' ./website/docs/*
./website/docs/r/alb_target_group_attachment.html.markdown:  // Other arguments
./website/docs/r/alb_target_group_attachment.html.markdown:  // Other arguments

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Aug 11, 2017
@radeksimko radeksimko merged commit 64ef5a4 into hashicorp:master Aug 11, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
vpc_peering_accepter correct comment syntax
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants