resource/aws_eks_node_group: add support for node_group_name prefixes

[dstevensson]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_eks_node_group: Add `node_group_name_prefix`.
resource/aws_eks_node_group: `node_group_name` is optional.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodeGroup_NamePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodeGroup_NamePrefix -timeout 120m
=== RUN   TestAccAWSEksNodeGroup_NamePrefix
=== PAUSE TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_NamePrefix
--- PASS: TestAccAWSEksNodeGroup_NamePrefix (1331.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1331.894s
...

This PR adds functionality to use prefixes for naming EKS node groups which allows you to use life cycle arguments such as create_before_destroy. node_group_name is moved to optional with with a random unique value if omitted.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodeGroup_basic\|TestAccAWSEksNodeGroup_Name_Generated\|TestAccAWSEksNodeGroup_NamePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodeGroup_basic\|TestAccAWSEksNodeGroup_Name_Generated\|TestAccAWSEksNodeGroup_NamePrefix -timeout 180m
=== RUN   TestAccAWSEksNodeGroup_basic
=== PAUSE TestAccAWSEksNodeGroup_basic
=== RUN   TestAccAWSEksNodeGroup_Name_Generated
=== PAUSE TestAccAWSEksNodeGroup_Name_Generated
=== RUN   TestAccAWSEksNodeGroup_NamePrefix
=== PAUSE TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_basic
=== CONT  TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_Name_Generated
--- PASS: TestAccAWSEksNodeGroup_basic (1047.30s)
--- PASS: TestAccAWSEksNodeGroup_NamePrefix (1133.09s)
--- PASS: TestAccAWSEksNodeGroup_Name_Generated (1245.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1248.609s

GovCloud

%  make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodeGroup_basic\|TestAccAWSEksNodeGroup_Name_Generated\|TestAccAWSEksNodeGroup_NamePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodeGroup_basic\|TestAccAWSEksNodeGroup_Name_Generated\|TestAccAWSEksNodeGroup_NamePrefix -timeout 180m
=== RUN   TestAccAWSEksNodeGroup_basic
=== PAUSE TestAccAWSEksNodeGroup_basic
=== RUN   TestAccAWSEksNodeGroup_Name_Generated
=== PAUSE TestAccAWSEksNodeGroup_Name_Generated
=== RUN   TestAccAWSEksNodeGroup_NamePrefix
=== PAUSE TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_basic
=== CONT  TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_Name_Generated
--- PASS: TestAccAWSEksNodeGroup_Name_Generated (969.59s)
--- PASS: TestAccAWSEksNodeGroup_basic (1030.53s)
--- PASS: TestAccAWSEksNodeGroup_NamePrefix (1085.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1088.459s

[ewbankkit]

@dstevensson Thanks for the contribution 👏.
In order to get this merged quicker I went ahead and modified the code a bit to meet our current conventions on resource name generation.
Other than that everything looks great.

[ghost]

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.