Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_eip - support NetworkBorderGroup attribute #14028

Merged
merged 6 commits into from
Nov 5, 2020
Merged

r/aws_eip - support NetworkBorderGroup attribute #14028

merged 6 commits into from
Nov 5, 2020

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Jul 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13998

Release note for CHANGELOG:

support NetworkBorderGroup attribute for aws_eip resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (22.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       22.843s

...

@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jul 2, 2020
@drexler drexler marked this pull request as ready for review July 2, 2020 11:36
@drexler drexler requested a review from a team July 2, 2020 11:36
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2020
@drexler
Copy link
Contributor Author

drexler commented Jul 5, 2020

Full tests - had to run them one by one

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (17.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.167s

 $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_basic -timeout 120m
=== RUN   TestAccAWSEIP_basic
=== PAUSE TestAccAWSEIP_basic
=== CONT  TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (21.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.072s


$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_instance'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_instance -timeout 120m
=== RUN   TestAccAWSEIP_instance
=== PAUSE TestAccAWSEIP_instance
=== CONT  TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (179.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	179.344s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_networkInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_networkInterface -timeout 120m
=== RUN   TestAccAWSEIP_networkInterface
=== PAUSE TestAccAWSEIP_networkInterface
=== CONT  TestAccAWSEIP_networkInterface
--- PASS: TestAccAWSEIP_networkInterface (41.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.810s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_twoEIPsOneNetworkInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_twoEIPsOneNetworkInterface -timeout 120m
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
=== PAUSE TestAccAWSEIP_twoEIPsOneNetworkInterface
=== CONT  TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (45.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.611s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_associated_user_private_ip'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_associated_user_private_ip -timeout 120m
=== RUN   TestAccAWSEIP_associated_user_private_ip
=== PAUSE TestAccAWSEIP_associated_user_private_ip
=== CONT  TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (135.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	135.592s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_Instance_Reassociate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_Instance_Reassociate -timeout 120m
=== RUN   TestAccAWSEIP_Instance_Reassociate
=== PAUSE TestAccAWSEIP_Instance_Reassociate
=== CONT  TestAccAWSEIP_Instance_Reassociate
--- PASS: TestAccAWSEIP_Instance_Reassociate (123.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	123.556s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_disappears -timeout 120m
=== RUN   TestAccAWSEIP_disappears
=== PAUSE TestAccAWSEIP_disappears
=== CONT  TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (11.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.824s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_tags -timeout 120m
=== RUN   TestAccAWSEIP_tags
=== PAUSE TestAccAWSEIP_tags
=== CONT  TestAccAWSEIP_tags
--- PASS: TestAccAWSEIP_tags (25.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.641s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIPAssociate_notAssociated'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIPAssociate_notAssociated -timeout 120m
=== RUN   TestAccAWSEIPAssociate_notAssociated
=== PAUSE TestAccAWSEIPAssociate_notAssociated
=== CONT  TestAccAWSEIPAssociate_notAssociated
--- PASS: TestAccAWSEIPAssociate_notAssociated (162.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	162.881s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_PublicIpv4Pool_default'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_PublicIpv4Pool_default -timeout 120m
=== RUN   TestAccAWSEIP_PublicIpv4Pool_default
=== PAUSE TestAccAWSEIP_PublicIpv4Pool_default
=== CONT  TestAccAWSEIP_PublicIpv4Pool_default
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (14.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.595s

@ewbankkit ewbankkit mentioned this pull request Aug 7, 2020
Closed
7 tasks
ewbankkit
ewbankkit reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (26.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.393s

@ewbankkit ewbankkit requested review from DrFaust92 and removed request for a team August 7, 2020 19:52
@cucxabong
Copy link

Any update on this ?

DrFaust92
DrFaust92 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSEIP_NetworkBorderGroup (61.10s)

@cucxabong
Copy link

think we could merge this @ewbankkit

bflad
bflad reviewed Oct 27, 2020
View reviewed changes
aws/resource_aws_eip_test.go Outdated Show resolved Hide resolved
ewbankkit
ewbankkit approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup\|TestAccAWSEIP_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup\|TestAccAWSEIP_basic -timeout 120m
=== RUN   TestAccAWSEIP_basic
=== PAUSE TestAccAWSEIP_basic
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_basic
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_basic (23.94s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (26.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.352s

@bflad bflad self-assigned this Nov 4, 2020
@bflad bflad added this to the v3.14.0 milestone Nov 4, 2020
bflad
bflad approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @drexler 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEIP_associated_user_private_ip (207.97s)
--- PASS: TestAccAWSEIP_basic (20.14s)
--- PASS: TestAccAWSEIP_disappears (12.47s)
--- PASS: TestAccAWSEIP_instance (106.47s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (162.39s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (20.14s)
--- PASS: TestAccAWSEIP_networkInterface (89.36s)
--- PASS: TestAccAWSEIP_notAssociated (117.01s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (19.01s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (4.88s)
--- PASS: TestAccAWSEIP_tags_Vpc (27.91s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (88.20s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.45s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)

@bflad bflad merged commit bdfcdf6 into hashicorp:master Nov 5, 2020
bflad added a commit that referenced this pull request Nov 5, 2020
@bflad
Update CHANGELOG for #14028
1bfc27b
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@drexler drexler deleted the eip-param branch November 6, 2020 01:22
@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.

aws_eip support new attributes NetworkBorderGroup and address
6 participants
@drexler @cucxabong @bflad @ewbankkit @DrFaust92 @breathingdust