Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updates for aws_ssm_association & aws_ssm_patch_baseline resources #1421

Merged
merged 6 commits into from
Aug 16, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 15, 2017

Fixes: #1296

aws_ssm_association:

  • parameters
  • schedule_expression
  • output_location
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (128.55s)
=== RUN   TestAccAWSSSMAssociation_withTargets
--- PASS: TestAccAWSSSMAssociation_withTargets (34.77s)
=== RUN   TestAccAWSSSMAssociation_withParameters
--- PASS: TestAccAWSSSMAssociation_withParameters (57.27s)
=== RUN   TestAccAWSSSMAssociation_withDocumentVersion
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (43.08s)
=== RUN   TestAccAWSSSMAssociation_withOutputLocation
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (153.91s)
=== RUN   TestAccAWSSSMAssociation_withScheduleExpression
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (59.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	476.632s

aws_ssm_patch_baseline

  • name
  • description
  • global_filter
  • approval_rule
  • approved_patches
  • rejected_patches
  • approved_patches_compliance_level
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMPatchBaseline -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (42.98s)
=== RUN   TestAccAWSSSMPatchBaselineWithOperatingSystem
--- PASS: TestAccAWSSSMPatchBaselineWithOperatingSystem (44.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.247s

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stack72 ! I confirmed with some tests locally, this looks great.

@catsby catsby merged commit 5558396 into hashicorp:master Aug 16, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
…urces (hashicorp#1421)

* Update SSM Association Schedule Expression

* Update SSM Association Output Location

* Add support for SSM Association Document Version

* Add acceptance test for AWS SSM Assocation with Parameters

* Add support for SSM Association Parameter Updates

* Add support for ssm_patch_baseline resource updates
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for updating SSM resource attributes
2 participants