Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include aws-sdk-go/service/s3/s3manager for multipart uploads #14231

Closed
wants to merge 1 commit into from
Closed

Include aws-sdk-go/service/s3/s3manager for multipart uploads #14231

wants to merge 1 commit into from

Conversation

pierrebeaucamp
Copy link

As requested by your contribution checklist, this is a PR for the
addition of the s3manager library to the vendored dependencies.

This package is needed to allow for multipart uploads to S3, as
described in #788.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #788

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

As requested by your contribution checklist, this is a PR for the
addition of the s3manager library to the vendored dependencies.

This package is needed to allow for multipart uploads to S3, as
described in #788.
@pierrebeaucamp pierrebeaucamp requested a review from a team July 17, 2020 19:02
@ghost ghost added dependencies Used to indicate dependency changes. needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. labels Jul 17, 2020
@ewbankkit
Copy link
Contributor

@bflad
Copy link
Contributor

bflad commented Jul 27, 2020

Superseded by #14221 👍

@bflad bflad closed this Jul 27, 2020
@pierrebeaucamp pierrebeaucamp deleted the v-s3manager branch July 27, 2020 19:13
@ghost
Copy link

ghost commented Aug 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 27, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants