Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test to catch terraform-provider-aws/issues/14280 #14282

Closed
wants to merge 1 commit into from
Closed

Acceptance test to catch terraform-provider-aws/issues/14280 #14282

wants to merge 1 commit into from

Conversation

dicconb
Copy link

@dicconb dicconb commented Jul 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14280

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
=== PAUSE TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
=== CONT  TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
--- FAIL: TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly (149.63s)
    testing.go:684: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_s3_bucket.bucket
          acceleration_status:                                        "" => ""
          acl:                                                        "private" => "private"
          arn:                                                        "arn:aws:s3:::tf-test-bucket-4703282864581065995" => "arn:aws:s3:::tf-test-bucket-4703282864581065995"
          bucket:                                                     "tf-test-bucket-4703282864581065995" => "tf-test-bucket-4703282864581065995"
          bucket_domain_name:                                         "tf-test-bucket-4703282864581065995.s3.amazonaws.com" => "tf-test-bucket-4703282864581065995.s3.amazonaws.com"
          bucket_regional_domain_name:                                "tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com" => "tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com"
          cors_rule.#:                                                "0" => "0"
          force_destroy:                                              "false" => "false"
          grant.#:                                                    "0" => "0"
          hosted_zone_id:                                             "Z3BJ6K6RIION7M" => "Z3BJ6K6RIION7M"
          id:                                                         "tf-test-bucket-4703282864581065995" => "tf-test-bucket-4703282864581065995"
          lifecycle_rule.#:                                           "1" => "1"
          lifecycle_rule.0.abort_incomplete_multipart_upload_days:    "7" => "7"
          lifecycle_rule.0.enabled:                                   "true" => "true"
          lifecycle_rule.0.expiration.#:                              "1" => "0"
          lifecycle_rule.0.expiration.0.date:                         "" => ""
          lifecycle_rule.0.expiration.0.days:                         "0" => ""
          lifecycle_rule.0.expiration.0.expired_object_delete_marker: "false" => ""
          lifecycle_rule.0.id:                                        "id1" => "id1"
          lifecycle_rule.0.noncurrent_version_expiration.#:           "0" => "0"
          lifecycle_rule.0.noncurrent_version_transition.#:           "0" => "0"
          lifecycle_rule.0.prefix:                                    "path1/" => "path1/"
          lifecycle_rule.0.transition.#:                              "0" => "0"
          logging.#:                                                  "0" => "0"
          object_lock_configuration.#:                                "0" => "0"
          region:                                                     "us-west-2" => "us-west-2"
          replication_configuration.#:                                "0" => "0"
          request_payer:                                              "BucketOwner" => "BucketOwner"
          server_side_encryption_configuration.#:                     "0" => "0"
          versioning.#:                                               "1" => "1"
          versioning.0.enabled:                                       "false" => "false"
          versioning.0.mfa_delete:                                    "false" => "false"
          website.#:                                                  "0" => "0"



        STATE:

        aws_s3_bucket.bucket:
          ID = tf-test-bucket-4703282864581065995
          provider = provider.aws
          acceleration_status =
          acl = private
          arn = arn:aws:s3:::tf-test-bucket-4703282864581065995
          bucket = tf-test-bucket-4703282864581065995
          bucket_domain_name = tf-test-bucket-4703282864581065995.s3.amazonaws.com
          bucket_regional_domain_name = tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com
          force_destroy = false
          hosted_zone_id = Z3BJ6K6RIION7M
          lifecycle_rule.# = 1
          lifecycle_rule.0.abort_incomplete_multipart_upload_days = 7
          lifecycle_rule.0.enabled = true
          lifecycle_rule.0.expiration.# = 1
          lifecycle_rule.0.expiration.0.date =
          lifecycle_rule.0.expiration.0.days = 0
          lifecycle_rule.0.expiration.0.expired_object_delete_marker = false
          lifecycle_rule.0.id = id1
          lifecycle_rule.0.prefix = path1/
          region = us-west-2
          request_payer = BucketOwner
          versioning.# = 1
          versioning.0.enabled = false
          versioning.0.mfa_delete = false
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	152.268s
FAIL
make: *** [testacc] Error 1

@dicconb dicconb requested a review from a team July 21, 2020 21:04
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 21, 2020
@dicconb
Copy link
Author

dicconb commented Jul 21, 2020

Acceptance test output reflects the current broken state

@dicconb
Copy link
Author

dicconb commented Jul 21, 2020

Closing to reopen with correct branch prefix

@dicconb dicconb closed this Jul 21, 2020
@dicconb dicconb deleted the issues/14280 branch July 21, 2020 22:10
@ghost
Copy link

ghost commented Aug 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 21, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants