Acceptance test to catch terraform-provider-aws/issues/14280

[dicconb]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14280

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
=== PAUSE TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
=== CONT  TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly
--- FAIL: TestAccAWSS3Bucket_Lifecycle_AbortIncompleteMultipartUploadOnly (149.63s)
    testing.go:684: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_s3_bucket.bucket
          acceleration_status:                                        "" => ""
          acl:                                                        "private" => "private"
          arn:                                                        "arn:aws:s3:::tf-test-bucket-4703282864581065995" => "arn:aws:s3:::tf-test-bucket-4703282864581065995"
          bucket:                                                     "tf-test-bucket-4703282864581065995" => "tf-test-bucket-4703282864581065995"
          bucket_domain_name:                                         "tf-test-bucket-4703282864581065995.s3.amazonaws.com" => "tf-test-bucket-4703282864581065995.s3.amazonaws.com"
          bucket_regional_domain_name:                                "tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com" => "tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com"
          cors_rule.#:                                                "0" => "0"
          force_destroy:                                              "false" => "false"
          grant.#:                                                    "0" => "0"
          hosted_zone_id:                                             "Z3BJ6K6RIION7M" => "Z3BJ6K6RIION7M"
          id:                                                         "tf-test-bucket-4703282864581065995" => "tf-test-bucket-4703282864581065995"
          lifecycle_rule.#:                                           "1" => "1"
          lifecycle_rule.0.abort_incomplete_multipart_upload_days:    "7" => "7"
          lifecycle_rule.0.enabled:                                   "true" => "true"
          lifecycle_rule.0.expiration.#:                              "1" => "0"
          lifecycle_rule.0.expiration.0.date:                         "" => ""
          lifecycle_rule.0.expiration.0.days:                         "0" => ""
          lifecycle_rule.0.expiration.0.expired_object_delete_marker: "false" => ""
          lifecycle_rule.0.id:                                        "id1" => "id1"
          lifecycle_rule.0.noncurrent_version_expiration.#:           "0" => "0"
          lifecycle_rule.0.noncurrent_version_transition.#:           "0" => "0"
          lifecycle_rule.0.prefix:                                    "path1/" => "path1/"
          lifecycle_rule.0.transition.#:                              "0" => "0"
          logging.#:                                                  "0" => "0"
          object_lock_configuration.#:                                "0" => "0"
          region:                                                     "us-west-2" => "us-west-2"
          replication_configuration.#:                                "0" => "0"
          request_payer:                                              "BucketOwner" => "BucketOwner"
          server_side_encryption_configuration.#:                     "0" => "0"
          versioning.#:                                               "1" => "1"
          versioning.0.enabled:                                       "false" => "false"
          versioning.0.mfa_delete:                                    "false" => "false"
          website.#:                                                  "0" => "0"



        STATE:

        aws_s3_bucket.bucket:
          ID = tf-test-bucket-4703282864581065995
          provider = provider.aws
          acceleration_status =
          acl = private
          arn = arn:aws:s3:::tf-test-bucket-4703282864581065995
          bucket = tf-test-bucket-4703282864581065995
          bucket_domain_name = tf-test-bucket-4703282864581065995.s3.amazonaws.com
          bucket_regional_domain_name = tf-test-bucket-4703282864581065995.s3.us-west-2.amazonaws.com
          force_destroy = false
          hosted_zone_id = Z3BJ6K6RIION7M
          lifecycle_rule.# = 1
          lifecycle_rule.0.abort_incomplete_multipart_upload_days = 7
          lifecycle_rule.0.enabled = true
          lifecycle_rule.0.expiration.# = 1
          lifecycle_rule.0.expiration.0.date =
          lifecycle_rule.0.expiration.0.days = 0
          lifecycle_rule.0.expiration.0.expired_object_delete_marker = false
          lifecycle_rule.0.id = id1
          lifecycle_rule.0.prefix = path1/
          region = us-west-2
          request_payer = BucketOwner
          versioning.# = 1
          versioning.0.enabled = false
          versioning.0.mfa_delete = false
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	152.268s
FAIL
make: *** [testacc] Error 1

[dicconb]

The test is expected to fail, as it covers a case where the latest provider doesn't currently converge (see #14280)

Fixed in #14284

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[anGie44]

Hi @dicconb , thanks again for opening this PR to validate the bug back in v2.64.0 of the provider. Since it was fixed back in v3.10.0 of the provider I'm going to close this PR, but again we appreciate you taking the time to contribute!

Reference: #15263

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.