resource/aws_rds_cluster_instance: Exposed availability_zone attribute #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninir
added
the
enhancement
Ninir
suggested changes
Aug 17, 2017
| @@ -296,6 +301,7 @@ func resourceAwsRDSClusterInstanceRead(d *schema.ResourceData, meta interface{}) | |||
| d.Set("promotion_tier", db.PromotionTier) | |||
| d.Set("preferred_backup_window", db.PreferredBackupWindow) | |||
| d.Set("preferred_maintenance_window", db.PreferredMaintenanceWindow) | |||
| d.Set("availability_zone", db.AvailabilityZone) | |||
There was a problem hiding this comment.
Could you augment an existing acceptance test to check for this to be set? perhaps the basic one?
There was a problem hiding this comment.
Hi @Ninir
I've added to the basic test now and passed.
Ninir
added
the
waiting-response
Ninir
changed the title
Ninir
removed
the
waiting-response
Ninir
approved these changes
Aug 17, 2017
There was a problem hiding this comment.
Looks good to me @kl4w !
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSClusterInstance_basic -timeout 120m
=== RUN TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_basic (1473.45s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1473.488s
Thanks for the work here :) Nice first contribution!
Ninir
changed the title
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
Set availability_zone attribute on RDS cluster instance
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR so let me know if I'm missing anything.
Current docs state that
aws_rds_cluster_instancereturns theavailability_zonesattribute but is not the case https://www.terraform.io/docs/providers/aws/r/rds_cluster_instance.html#availability_zonesEnhanced resource to set the attribute and remove plural from docs.