Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/rds_cluster: validate cluster auth in non-replicas #14502

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14490
Relates #14491

Release note for CHANGELOG:

resource/rds_cluster: validate cluster auth in non-replicas

Output from acceptance testing(before):

    TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId: testing.go:684: Step 0 error: errors during apply:
        Error: provider.aws: aws_db_instance: : "master_password": required field is not set

Output from acceptance testing(after):

--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1594.43s)

Additional test output:

--- FAIL: TestAccAWSRDSCluster_s3Restore (1518.12s) -- known failure 
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1089.27s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1128.94s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (628.32s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (711.88s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1254.88s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1011.89s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1338.02s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (831.11s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (789.12s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (795.76s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (780.55s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (787.99s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (883.25s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (775.47s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (774.64s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (852.74s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (807.61s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (818.39s)
--- PASS: TestAccAWSRDSClusterInstance_az (580.93s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1375.98s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (1375.44s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (798.02s)
--- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (815.75s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (1399.27s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (620.34s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (123.06s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (141.41s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (122.25s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (147.18s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (179.02s)
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (341.15s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (313.53s)
--- PASS: TestAccAWSRDSCluster_EngineMode (393.22s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (142.45s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (116.57s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (151.79s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (415.61s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1650.15s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global (157.37s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Add (146.64s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Remove (163.46s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Update (150.65s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned (148.33s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1953.54s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier (1904.45s)
--- PASS: TestAccAWSRDSCluster_Port (272.94s)
--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1538.65s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (333.77s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity (300.90s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (386.29s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (381.14s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (370.51s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (423.25s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (353.72s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (360.99s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (381.83s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (372.19s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (332.03s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (380.44s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (340.09s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (359.76s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (351.13s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (351.72s)
--- PASS: TestAccAWSRDSCluster_Tags (115.41s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (149.06s)
--- PASS: TestAccAWSRDSCluster_basic (132.06s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (195.37s)
--- PASS: TestAccAWSRDSCluster_encrypted (120.00s)
--- PASS: TestAccAWSRDSCluster_generatedName (122.23s)
--- PASS: TestAccAWSRDSCluster_iamAuth (132.55s)
--- PASS: TestAccAWSRDSCluster_kmsKey (116.64s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (4.39s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (163.28s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (149.87s)

@anGie44 anGie44 requested a review from a team August 7, 2020 13:52
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. labels Aug 7, 2020
@anGie44 anGie44 marked this pull request as draft August 7, 2020 13:52
@anGie44 anGie44 force-pushed the b-rds-cluster-test branch 2 times, most recently from 7f807ae to 05e2608 Compare August 7, 2020 16:05
@anGie44 anGie44 marked this pull request as ready for review August 7, 2020 16:07
@anGie44 anGie44 marked this pull request as draft August 7, 2020 16:49
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 7, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 7, 2020
@anGie44 anGie44 marked this pull request as ready for review August 7, 2020 16:57
@bflad bflad added this to the v3.1.0 milestone Aug 7, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Aug 7, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance testing looks good! 🚀

@bflad bflad merged commit 73cf988 into master Aug 7, 2020
@bflad bflad deleted the b-rds-cluster-test branch August 7, 2020 23:00
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants