Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech-debt/db_instance: update to an engine without versioning restrictions for enabling cloudwatch logs #14526

Merged
merged 1 commit into from
Aug 10, 2020
Merged

tech-debt/db_instance: update to an engine without versioning restrictions for enabling cloudwatch logs #14526

merged 1 commit into from
Aug 10, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14384

Release note for CHANGELOG:

tech-debt/db_instance: update to an engine without versioning restrictions for enabling cloudwatch logs

Output from acceptance testing:

--- PASS: TestAccAWSDbInstanceDataSource_basic (532.77s)

@anGie44 anGie44 requested a review from a team August 8, 2020 05:49
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 8, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 8, 2020
@breathingdust breathingdust mentioned this pull request Aug 10, 2020
Closed
6 tasks
@bflad bflad self-assigned this Aug 10, 2020
@bflad bflad added this to the v3.2.0 milestone Aug 10, 2020
bflad
bflad approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing this, @anGie44! 🚀 (We can consider making the basic test more basic in the future potentially as part of #8223)

Output from acceptance testing:

--- PASS: TestAccAWSDbInstanceDataSource_basic (518.50s)

@anGie44 anGie44 merged commit de60135 into master Aug 10, 2020
@anGie44 anGie44 deleted the td-db-instance-data-source-basic branch August 10, 2020 20:22
@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @bflad