Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws_ecs_task_definition docs markdown links #14848

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Fix aws_ecs_task_definition docs markdown links #14848

merged 1 commit into from
Aug 28, 2020

Conversation

henare
Copy link
Contributor

@henare henare commented Aug 26, 2020

It looks like these were broken due to line wrapping.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

@henare
Fix aws_ecs_task_definition docs markdown links
f688bfc 
It looks like these were broken due to line wrapping.
@henare henare requested a review from a team August 26, 2020 03:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. documentation Introduces or discusses updates to documentation. labels Aug 26, 2020
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 28, 2020
anGie44
anGie44 approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @henare, looks great! 🚀

@anGie44 anGie44 added this to the v3.5.0 milestone Aug 28, 2020
@anGie44 anGie44 merged commit a4e7ff5 into hashicorp:master Aug 28, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@henare @anGie44