[WIP] r/aws_route: Correctly handle update of route target #15049

ewbankkit · 2020-09-06T00:58:10Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #684.
Closes #2270.
Closes #11455.
Closes #12631.
Closes #13302.
Closes #13079.
Closes #14995.

Uses additional tests cases from #14014.

Includes functionality from #12062.

I will address some similar problems for the aws_route_table (and aws_default_route_table) resources in a separate PR.

Release note for CHANGELOG:

resource/aws_route: Correctly handle updates to the route target attributes (`egress_only_gateway_id`, `gateway_id`, `instance_id`, `nat_gateway_id`, `network_interface_id`, `network_interface_id`, `transit_gateway_id`, `vpc_peering_connection_id`)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== RUN   TestAccAWSRoute_LocalRoute
=== PAUSE TestAccAWSRoute_LocalRoute
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_basic (46.39s)
=== CONT  TestAccAWSRoute_LocalRoute
--- PASS: TestAccAWSRoute_LocalRoute (26.17s)
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (130.67s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (260.80s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (60.86s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (2.00s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.58s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_Update_Target (492.60s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (340.25s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (46.73s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (341.44s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (181.11s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (32.85s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (33.15s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (33.54s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_Instance (81.09s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (136.87s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (43.10s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (42.16s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (38.38s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (32.82s)
=== CONT  TestAccAWSRoute_routeTableDisappears
    resource_aws_route_test.go:182: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_routeTableDisappears (37.07s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_Instance (93.57s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (43.33s)
=== CONT  TestAccAWSRoute_disappears
    resource_aws_route_test.go:158: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_disappears (36.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1324.816s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (53.08s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 53.129s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (49.64s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 49.690s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_changeCidr' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_changeCidr -timeout 120m === RUN TestAccAWSRoute_changeCidr === PAUSE TestAccAWSRoute_changeCidr === CONT TestAccAWSRoute_changeCidr --- PASS: TestAccAWSRoute_changeCidr (77.60s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 77.646s

…_ipv6ToEgressOnlyInternetGateway'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway -timeout 120m === RUN TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway === PAUSE TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway === CONT TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway --- PASS: TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway (61.15s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 61.206s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (52.29s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 52.339s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_changeCidr' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_changeCidr -timeout 120m === RUN TestAccAWSRoute_changeCidr === PAUSE TestAccAWSRoute_changeCidr === CONT TestAccAWSRoute_changeCidr --- PASS: TestAccAWSRoute_changeCidr (78.93s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 79.529s

…nctionality.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_doesNotCrashWithVPCEndpoint' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_doesNotCrashWithVPCEndpoint -timeout 120m === RUN TestAccAWSRoute_doesNotCrashWithVPCEndpoint === PAUSE TestAccAWSRoute_doesNotCrashWithVPCEndpoint === CONT TestAccAWSRoute_doesNotCrashWithVPCEndpoint --- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (62.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 62.882s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToInternetGateway -timeout 120m === RUN TestAccAWSRoute_ipv6ToInternetGateway === PAUSE TestAccAWSRoute_ipv6ToInternetGateway === CONT TestAccAWSRoute_ipv6ToInternetGateway --- PASS: TestAccAWSRoute_ipv6ToInternetGateway (51.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 52.050s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToInstance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToInstance -timeout 120m === RUN TestAccAWSRoute_ipv6ToInstance === PAUSE TestAccAWSRoute_ipv6ToInstance === CONT TestAccAWSRoute_ipv6ToInstance --- PASS: TestAccAWSRoute_ipv6ToInstance (111.03s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 111.103s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToNetworkInterface' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToNetworkInterface -timeout 120m === RUN TestAccAWSRoute_ipv6ToNetworkInterface === PAUSE TestAccAWSRoute_ipv6ToNetworkInterface === CONT TestAccAWSRoute_ipv6ToNetworkInterface --- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (47.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.969s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToVpcPeeringConnection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToVpcPeeringConnection -timeout 120m === RUN TestAccAWSRoute_ipv6ToVpcPeeringConnection === PAUSE TestAccAWSRoute_ipv6ToVpcPeeringConnection === CONT TestAccAWSRoute_ipv6ToVpcPeeringConnection --- PASS: TestAccAWSRoute_ipv6ToVpcPeeringConnection (44.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 44.054s

…rBlock' and rename tests. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_InternetGateway === PAUSE TestAccAWSRoute_IPv4_To_InternetGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.94s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_basic (51.95s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.30s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (61.41s) === CONT TestAccAWSRoute_IPv4_To_InternetGateway --- PASS: TestAccAWSRoute_IPv4_To_InternetGateway (76.58s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (53.22s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (47.85s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (315.51s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.04s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.96s) --- PASS: TestAccAWSRoute_IPv6_To_Instance (129.66s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 488.049s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (87.65s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 87.699s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (47.04s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.100s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_VpcPeeringConnection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_VpcPeeringConnection -timeout 120m === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.88s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 42.928s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NatGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NatGateway -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (195.61s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 195.647s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_InternetGateway === PAUSE TestAccAWSRoute_IPv4_To_InternetGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (52.44s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.36s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (358.76s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (62.15s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (195.36s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (43.17s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (46.84s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (120.01s) === CONT TestAccAWSRoute_IPv4_To_InternetGateway --- PASS: TestAccAWSRoute_IPv4_To_InternetGateway (77.57s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.36s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (48.01s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_Instance (119.62s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (51.75s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (58.58s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.56s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1400.609s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_VpnGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_VpnGateway -timeout 120m === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (63.35s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 63.423s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_VpnGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv6_To_VpnGateway -timeout 120m === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (56.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 56.281s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_basic (52.59s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.45s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (129.99s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (63.26s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (205.43s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (43.54s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (33.36s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (347.29s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (33.84s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (55.26s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (62.51s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.95s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (52.13s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.35s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_IPv6_To_Instance (119.68s) --- PASS: TestAccAWSRoute_disappears (48.50s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 731.979s

…RouteTableNumberOfRoutes'.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_routeTableDisappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_routeTableDisappears -timeout 120m === RUN TestAccAWSRoute_routeTableDisappears === PAUSE TestAccAWSRoute_routeTableDisappears === CONT TestAccAWSRoute_routeTableDisappears --- PASS: TestAccAWSRoute_routeTableDisappears (48.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 48.910s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ConditionalCidrBlock' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ConditionalCidrBlock -timeout 120m === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.68s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 76.752s

…to test route to ENI attached to an instance. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (113.54s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 113.607s

…ents' to test route to 2 ENIs attached to the same instance (hashicorp#2270). Acceptance test output (failure expected): $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- FAIL: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (127.29s) testing.go:684: Step 1 error: errors during apply: Error: InvalidInstanceID: There are multiple interfaces attached to instance 'i-005065eb4850f01a4'. Please specify an interface ID for the operation instead. status code: 400, request id: f601a6af-729a-4830-835b-be8887b0c3ee on /tmp/tf-test358593801/main.tf line 98: (source code not available) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 127.347s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

…rface_TwoAttachments'.

…es' data source.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv6_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_Instance (128.20s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 128.262s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (116.72s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 116.766s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (330.31s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 330.352s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_TransitGateway' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_IPv6_To_TransitGateway -timeout 120m === RUN TestAccAWSRoute_IPv6_To_TransitGateway === PAUSE TestAccAWSRoute_IPv6_To_TransitGateway === CONT TestAccAWSRoute_IPv6_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (352.10s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 352.141s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_LocalGateway' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_IPv6_To_LocalGateway -timeout 120m === RUN TestAccAWSRoute_IPv6_To_LocalGateway === PAUSE TestAccAWSRoute_IPv6_To_LocalGateway === CONT TestAccAWSRoute_IPv6_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found --- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (2.13s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2.185s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (51.48s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 51.542s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (40.57s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 40.615s $ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteDataSource_basic -timeout 120m === RUN TestAccAWSRouteDataSource_basic === PAUSE TestAccAWSRouteDataSource_basic === CONT TestAccAWSRouteDataSource_basic --- PASS: TestAccAWSRouteDataSource_basic (82.16s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 82.202s

… to shared with route table resources.

…id' are not Computed.

…hich should be usable from route table resources.

…d 'map[string]interface{}' when reading attributes.

ewbankkit · 2020-09-06T01:02:35Z

Based on #14014 with:

git cherry-pick c69ddbb68a1be9d78cf74a9c66768c9cc6398d4c
git cherry-pick 2fe968e98f6b7c74403b4b00995fb46f39eee887
git cherry-pick b5df80ef4d9d8b8952dcb911c94db21e0ef5daab
git cherry-pick fa437ebadd7f9078b133fe0838dd1329611b460d
git cherry-pick c8058fbc95b75075a100755d00d7c729b73a818d
git cherry-pick d81a6dbc7e26482a05d92c18c9f38e3f3c9e7cd8
git cherry-pick c68fd27d708682fe30b9f10b7e12afe82e0f1dd9
git cherry-pick 798fdf4fc7f5dd96e11e9ff7b0e1be63e15c9e9a
git cherry-pick eb479da38a9787acd18383e62d7e2de3e07b5c20
git cherry-pick 179d6d4a43cc3bbbb78b7cdd48fcab630e34d22b
git cherry-pick b90723cecd7869c9618ddf6f59c4e00b896bf7be
git cherry-pick 36768519c0c1ef96a2263eb3385cd72d4aee30eb
git cherry-pick 8a7d50c72454bcf543ce7b96b29f7102ff40f30a
git cherry-pick 647a134fb2cb62808693f7547e934eaaf87b3b1d
git cherry-pick d8c7cc4fa08b1548dda16c10e6ce759c122b1460
git cherry-pick 17934fdbe8a3ca02665d8d99ca70dc387ddbfa93
git cherry-pick 4ab10fd3db8294818dea0267a5dd54360d40a89c
git cherry-pick 137e9f9c003ad522ff692c0e918dc215a5da7454
git cherry-pick ec1720f6c6a3ec78bbe671e2a0ff350460206906
git cherry-pick 3edb1d981c4bcca655643a4a4bce23af2b0e5691
git cherry-pick 5591a1d33fd9858efc5c057f8841cbdf89819b9b

ewbankkit · 2020-09-06T01:07:24Z

aws/resource_aws_route.go

+		return fmt.Errorf("error updating Route for Route Table (%s) with destination (%s): %s", routeTableID, destination, err)
+	}
+
+	return resourceAwsRouteRead(d, meta)


Read after Update.

ewbankkit · 2020-09-06T01:07:43Z

aws/data_source_aws_route.go

@@ -202,3 +204,16 @@ func getRoutes(table *ec2.RouteTable, d *schema.ResourceData) []*ec2.Route {
 	}
 	return routes
 }
+
+// Helper: Create an ID for a route
+func resourceAwsRouteID(d *schema.ResourceData, r *ec2.Route) string {


Moved here temporarily. Will need to clean up when support for managed prefix list IDs added.

…arget attributes aren't specified.

ewbankkit · 2020-10-19T21:47:10Z

Replaced by #15723.

ghost · 2020-11-19T17:10:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit added 30 commits September 4, 2020 13:30

Remove 'TestAccAWSRoute_noopdiff'. Test steps implicitly test this fu…

e300f4c

…nctionality.

r/aws_route: Test computed attributes.

f7d8deb

r/aws_route: 'testAccCheckAWSRouteNumberOfRoutes' -> 'testAccCheckAWS…

69a8fb7

…RouteTableNumberOfRoutes'.

r/aws_route: Comment out failing 'TestAccAWSRoute_IPv4_To_NetworkInte…

27f943b

…rface_TwoAttachments'.

r/aws_route: Use 'available' as the name of the 'aws_availability_zon…

627589a

…es' data source.

Use 'testAccAvailableAZsNoOptInDefaultExcludeConfig'.

14f2e58

r/aws_route: Add 'TestAccAWSRoute_IPv4_Update_Target'. Currently fails.

b51d0bb

ewbankkit added 11 commits September 5, 2020 18:00

Use 'testAccAvailableAZsNoOptInDefaultExcludeConfig'.

158d780

Tweak EC2 error code constants.

cc2f8fb

Use 'tfnet.CIDRBlocksEqual' for IPv4 destination CIDR blocks.

3affa49

Tidy up route destination and target attribute checking in an attempt…

f0cefd8

… to shared with route table resources.

r/aws_route: 'gateway_id', 'egress_only_gateway_id' and 'nat_gateway_…

99f150e

…id' are not Computed.

r/aws_route: Add 'getRouteDestinationAndTargetAttributeKeysFromMap' w…

67a569d

…hich should be usable from route table resources.

r/aws_route: Minor tweak to error messages.

f4f54b0

r/aws_route: Tweak route attribute IP version support.

dd110e1

r/aws_route: Use interface to abstract over '*schema.ResourceData' an…

50234dc

…d 'map[string]interface{}' when reading attributes.

ewbankkit requested a review from a team September 6, 2020 00:58

ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 6, 2020

ewbankkit mentioned this pull request Sep 6, 2020

r/aws_route: Correctly handle update of route target #14796

Closed

ewbankkit commented Sep 6, 2020

View reviewed changes

r/aws_route: Add 'local_gateway_id' to attribute checking.

275b329

ewbankkit force-pushed the b-various-aws_route-fixes-MarkIV branch from 5122c05 to 275b329 Compare September 6, 2020 10:16

r/aws_route: Add plan-time validation that multiple destination and t…

2909c2a

…arget attributes aren't specified.

ewbankkit changed the title ~~r/aws_route: Correctly handle update of route target~~ [WIP] r/aws_route: Correctly handle update of route target Oct 4, 2020

ewbankkit mentioned this pull request Oct 19, 2020

[WIP] r/aws_route: Correctly handle update of route target #15723

Closed

ewbankkit closed this Oct 19, 2020

ewbankkit deleted the b-various-aws_route-fixes-MarkIV branch October 19, 2020 21:47

ewbankkit mentioned this pull request Nov 16, 2020

r/aws_route: Correctly handle update of route target #16219

Closed

ghost locked as resolved and limited conversation to collaborators Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] r/aws_route: Correctly handle update of route target #15049

[WIP] r/aws_route: Correctly handle update of route target #15049

ewbankkit commented Sep 6, 2020 •

edited

Loading

ewbankkit commented Sep 6, 2020 •

edited

Loading

ewbankkit Sep 6, 2020

ewbankkit Sep 6, 2020

ewbankkit commented Oct 19, 2020

ghost commented Nov 19, 2020

[WIP] r/aws_route: Correctly handle update of route target #15049

[WIP] r/aws_route: Correctly handle update of route target #15049

Conversation

ewbankkit commented Sep 6, 2020 • edited Loading

Community Note

ewbankkit commented Sep 6, 2020 • edited Loading

ewbankkit Sep 6, 2020

Choose a reason for hiding this comment

ewbankkit Sep 6, 2020

Choose a reason for hiding this comment

ewbankkit commented Oct 19, 2020

ghost commented Nov 19, 2020

ewbankkit commented Sep 6, 2020 •

edited

Loading

ewbankkit commented Sep 6, 2020 •

edited

Loading