Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Add precheck (Lex) #15588

Merged
merged 1 commit into from
Oct 15, 2020
Merged

tests/provider: Add precheck (Lex) #15588

merged 1 commit into from
Oct 15, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Close #14893, Relates #14188

Release note for CHANGELOG:

NONE

The output from acceptance testing (GovCloud):

    provider_test.go:544: skipping tests; partition aws-us-gov does not support models.lex service
--- SKIP: TestAccDataSourceAwsLexBot_basic (0.00s)
--- SKIP: TestAccAwsLexBot_basic (0.00s)
--- SKIP: TestAccDataSourceAwsLexIntent_basic (0.00s)
--- SKIP: TestAccAwsLexBotAlias_conversationLogsText (0.00s)
--- SKIP: TestAccAwsLexBotAlias_conversationLogsAudio (0.00s)
--- SKIP: TestAccAwsLexBot_clarificationPrompt (0.00s)
--- SKIP: TestAccAwsLexBot_abortStatement (0.00s)
--- SKIP: TestAccAwsLexBotAlias_conversationLogsBoth (0.00s)
--- SKIP: TestAccAwsLexBotAlias_disappears (0.00s)
--- SKIP: TestAccAwsLexBotAlias_description (0.00s)
--- PASS: TestAccAwsLexBot_version_serial (1.32s)
--- SKIP: TestAccDataSourceAwsLexSlotType_basic (0.00s)
--- SKIP: TestAccDataSourceAwsLexSlotType_withVersion (0.00s)
--- SKIP: TestAccAwsLexBotAlias_basic (0.00s)
--- SKIP: TestAccAwsLexBot_childDirected (0.00s)
--- SKIP: TestAccAwsLexBot_detectSentiment (0.00s)
--- SKIP: TestAccDataSourceAwsLexIntent_withVersion (0.00s)
--- SKIP: TestAccAwsLexBot_description (0.00s)
--- SKIP: TestAccAwsLexBot_voiceId (0.00s)
--- SKIP: TestAccAwsLexBot_enableModelImprovements (0.00s)
--- SKIP: TestAccAwsLexBot_locale (0.00s)
--- SKIP: TestAccAwsLexBot_intents (0.00s)
--- SKIP: TestAccAwsLexIntent_confirmationPromptAndRejectionStatement (0.00s)
--- SKIP: TestAccAwsLexIntent_dialogCodeHook (0.00s)
--- SKIP: TestAccAwsLexIntent_basic (0.00s)
--- SKIP: TestAccAwsLexIntent_slots (0.00s)
--- SKIP: TestAccAwsLexIntent_followUpPrompt (0.00s)
--- SKIP: TestAccAwsLexIntent_sampleUtterances (0.00s)
--- SKIP: TestAccAwsLexIntent_fulfillmentActivity (0.00s)
--- SKIP: TestAccAwsLexBot_idleSessionTtlInSeconds (0.00s)
--- SKIP: TestAccAwsLexBot_disappears (0.00s)
--- SKIP: TestAccAwsLexIntent_createVersion (0.00s)
--- SKIP: TestAccAwsLexIntent_conclusionStatement (0.00s)
--- SKIP: TestAccAwsLexIntent_slotsCustom (0.00s)
--- SKIP: TestAccAwsLexIntent_updateWithExternalChange (0.00s)
--- SKIP: TestAccAwsLexSlotType_enumerationValues (0.00s)
--- SKIP: TestAccAwsLexSlotType_description (0.00s)
--- SKIP: TestAccAwsLexSlotType_name (0.00s)
--- SKIP: TestAccAwsLexSlotType_disappears (0.00s)
--- SKIP: TestAccAwsLexSlotType_basic (0.00s)
--- SKIP: TestAccAwsLexIntent_disappears (0.00s)
--- SKIP: TestAccAwsLexSlotType_createVersion (0.00s)
--- SKIP: TestAccAwsLexSlotType_valueSelectionStrategy (0.00s)

The output from acceptance testing (commercial):

--- PASS: TestAccDataSourceAwsLexSlotType_basic (53.90s)
--- PASS: TestAccDataSourceAwsLexIntent_basic (55.19s)
--- PASS: TestAccDataSourceAwsLexIntent_withVersion (55.78s)
--- PASS: TestAccDataSourceAwsLexSlotType_withVersion (56.91s)
--- PASS: TestAccAwsLexBotAlias_basic (69.99s)
--- PASS: TestAccAwsLexBotAlias_disappears (108.59s)
--- PASS: TestAccAwsLexBot_description (118.23s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsAudio (123.63s)
--- PASS: TestAccAwsLexBot_idleSessionTtlInSeconds (124.79s)
--- PASS: TestAccAwsLexIntent_basic (55.85s)
--- PASS: TestAccDataSourceAwsLexBot_basic (157.69s)
--- PASS: TestAccAwsLexBot_voiceId (109.97s)
--- PASS: TestAccAwsLexBot_disappears (111.59s)
--- PASS: TestAccAwsLexIntent_createVersion (60.94s)
--- PASS: TestAccAwsLexIntent_conclusionStatement (56.78s)
--- PASS: TestAccAwsLexIntent_confirmationPromptAndRejectionStatement (53.59s)
--- PASS: TestAccAwsLexIntent_followUpPrompt (53.10s)
--- PASS: TestAccAwsLexIntent_dialogCodeHook (56.01s)
--- PASS: TestAccAwsLexBot_clarificationPrompt (194.08s)
--- PASS: TestAccAwsLexIntent_disappears (19.07s)
--- PASS: TestAccAwsLexIntent_slots (55.59s)
--- PASS: TestAccAwsLexSlotType_basic (49.31s)
--- PASS: TestAccAwsLexIntent_updateWithExternalChange (51.68s)
--- PASS: TestAccAwsLexSlotType_createVersion (51.47s)
--- PASS: TestAccAwsLexBot_basic (234.68s)
--- PASS: TestAccAwsLexBot_detectSentiment (238.80s)
--- PASS: TestAccAwsLexSlotType_disappears (14.13s)
--- PASS: TestAccAwsLexSlotType_description (50.19s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsBoth (248.09s)
--- PASS: TestAccAwsLexBot_enableModelImprovements (250.79s)
--- PASS: TestAccAwsLexBot_childDirected (252.81s)
--- PASS: TestAccAwsLexSlotType_enumerationValues (62.45s)
--- PASS: TestAccAwsLexIntent_fulfillmentActivity (100.58s)
--- PASS: TestAccAwsLexSlotType_valueSelectionStrategy (30.27s)
--- PASS: TestAccAwsLexSlotType_name (36.99s)
--- PASS: TestAccAwsLexBot_abortStatement (292.00s)
--- PASS: TestAccAwsLexIntent_sampleUtterances (129.65s)
--- PASS: TestAccAwsLexBot_intents (251.58s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsText (308.89s)
--- FAIL: TestAccAwsLexBot_version_serial (311.31s)
--- PASS: TestAccAwsLexBot_locale (259.23s)
--- PASS: TestAccAwsLexIntent_slotsCustom (148.16s)
--- FAIL: TestAccAwsLexBotAlias_description (320.56s)

@YakDriver YakDriver requested a review from a team October 9, 2020 22:34
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/lexmodels Issues and PRs that pertain to the lexmodels service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 9, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 9, 2020
@bflad bflad self-assigned this Oct 15, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and skips as expected! 🚀

@YakDriver YakDriver added this to the v3.12.0 milestone Oct 15, 2020
@YakDriver YakDriver merged commit 4e6c4bd into master Oct 15, 2020
@YakDriver YakDriver deleted the t-gov-lex-pre branch October 15, 2020 21:13
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/lexmodels Issues and PRs that pertain to the lexmodels service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add acceptance test preCheck for Lex in GovCloud
2 participants