Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Add PreChecks (AppMesh) #15886

Merged
merged 1 commit into from
Oct 29, 2020
Merged

tests/provider: Add PreChecks (AppMesh) #15886

merged 1 commit into from
Oct 29, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14361
Fixes #15888

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSAppmesh_serial (54.67s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (12.82s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/basic (1.52s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/tls (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/tags (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualNode/logging (1.24s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (2.49s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualRouter/tags (1.24s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualRouter/basic (1.25s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (3.79s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualService/virtualNode (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualService/tags (1.28s)
    --- PASS: TestAccAWSAppmesh_serial/GatewayRoute (7.54s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/tags (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/basic (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/disappears (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/grpcRoute (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/httpRoute (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/GatewayRoute/http2Route (1.26s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (3.82s)
        --- SKIP: TestAccAWSAppmesh_serial/Mesh/basic (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/Mesh/egressFilter (1.28s)
        --- SKIP: TestAccAWSAppmesh_serial/Mesh/tags (1.28s)
    --- PASS: TestAccAWSAppmesh_serial/Route (15.29s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/grpcRoute (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/http2Route (1.30s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/httpRoute (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/routePriority (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/tcpRoute (1.37s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (1.30s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/httpHeader (1.26s)
        --- SKIP: TestAccAWSAppmesh_serial/Route/tags (1.26s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (8.92s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/tls (1.28s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (1.29s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/basic (1.25s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/disappears (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (1.27s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/logging (1.28s)
        --- SKIP: TestAccAWSAppmesh_serial/VirtualGateway/tags (1.27s)

Output from acceptance testing (commercial):

kommer snart

@YakDriver YakDriver requested a review from a team October 28, 2020 15:50
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2020
@YakDriver YakDriver mentioned this pull request Oct 28, 2020
Closed
ewbankkit
ewbankkit approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Validated in us-west-2:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/disappears
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/tags
=== RUN   TestAccAWSAppmesh_serial/GatewayRoute/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
--- PASS: TestAccAWSAppmesh_serial (1917.03s)
    --- PASS: TestAccAWSAppmesh_serial/Route (573.19s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (42.22s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (44.00s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (41.35s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (59.06s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (41.26s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (41.46s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (60.31s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (59.18s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (41.59s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (41.24s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (41.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (59.96s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (280.43s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (50.60s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tls (85.60s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (36.56s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (20.01s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (16.91s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (35.40s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (35.34s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (518.70s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (39.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (36.42s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (87.85s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (52.76s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (20.45s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (36.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (108.50s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (36.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (36.00s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (63.74s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (85.46s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (34.83s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (50.63s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (135.98s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (40.75s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (37.16s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (58.07s)
    --- PASS: TestAccAWSAppmesh_serial/GatewayRoute (220.72s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/disappears (19.42s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/grpcRoute (40.32s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/httpRoute (40.00s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/http2Route (40.27s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/tags (57.23s)
        --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/basic (23.47s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (102.56s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (17.55s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (39.41s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (45.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1917.097s

@YakDriver
Copy link
Member Author

@ewbankkit Awesome. Thanks, Kit!

@YakDriver YakDriver added this to the v3.13.0 milestone Oct 29, 2020
@YakDriver YakDriver merged commit 2b6a2b2 into master Oct 29, 2020
@YakDriver YakDriver deleted the t-gov-appmesh branch October 29, 2020 18:02
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/appmesh Issues and PRs that pertain to the appmesh service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

tests/provider: Missing PreChecks (AppMesh)
2 participants
@YakDriver @ewbankkit