resource/aws_rds_cluster: Prevent restored cluster recreation with kms_key_id and lack of storage_encrypted, add testing and documentation #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_key_id and lack of storage_encrypted, add testing and documentation Reference: #3503 Output from acceptance testing: ``` --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId (395.41s) ```
ghost
added
size/M
|
I'm working on separately fixing these problematic tests: |
|
See #15938 for those unrelated testing issues and fixes. |
anGie44
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Change here LGTM 👍
Output of tests (ignoring global cluster failures):
-- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (627.58s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (628.78s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (690.08s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (690.29s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (693.87s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (714.93s)
--- PASS: TestAccAWSRDSClusterInstance_az (737.04s)
--- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (745.06s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (755.53s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (757.60s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (757.81s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (784.10s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (784.37s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (803.63s)
--- PASS: TestAccAWSRDSCluster_basic (125.89s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (843.39s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (5.18s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (116.76s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (126.89s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (130.68s)
--- PASS: TestAccAWSRDSCluster_generatedName (126.12s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (168.55s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (166.09s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql (125.93s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (991.15s)
--- PASS: TestAccAWSRDSCluster_Tags (147.62s)
--- PASS: TestAccAWSRDSCluster_kmsKey (126.16s)
--- PASS: TestAccAWSRDSCluster_encrypted (117.36s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (144.78s)
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1036.83s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL (208.97s)
--- PASS: TestAccAWSRDSCluster_iamAuth (127.66s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (130.78s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (240.73s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (188.38s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1177.50s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (188.44s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (572.87s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (166.50s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (513.05s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1293.05s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned (149.16s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (657.29s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (741.32s)
--- PASS: TestAccAWSRDSCluster_Port (248.25s)
--- PASS: TestAccAWSRDSCluster_EngineMode (441.91s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (773.99s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1480.61s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (443.13s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (368.54s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity (307.09s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (342.72s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (363.55s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (394.98s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (404.23s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (384.59s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (423.97s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId (364.32s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (355.28s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (354.46s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (384.89s)
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1139.91s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (413.84s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (423.63s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (384.93s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (374.78s)
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (358.44s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1157.33s)
--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1486.16s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1691.40s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier (1755.41s)
|
This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
Used it and now the delete with a secondary cluster went fine! Nice. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #3503
Release note for CHANGELOG:
Please note that previously restoring an unencrypted
snapshot_identifierdid create an encrypted cluster withkms_key_idargument, it just also requiredstorage_encryption = trueto prevent resource recreation immediately afterwards. We intend to apply similar fixes to other RDS resources, such asaws_rds_global_clusterfor restore situations like these.Output from acceptance testing: