Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with latest redshift service account ID's #1614

Merged
merged 1 commit into from
Sep 7, 2017
Merged

updated with latest redshift service account ID's #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions aws/data_source_aws_redshift_service_account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ var redshiftServiceAccountPerRegionMap = map[string]string{
"ca-central-1": "907379612154",
"eu-central-1": "053454850223",
"eu-west-1": "210876761215",
"eu-west-2": "307160386991",
"sa-east-1": "075028567923",
}

func dataSourceAwsRedshiftServiceAccount() *schema.Resource {
Expand Down
4 changes: 2 additions & 2 deletions aws/data_source_aws_redshift_service_account_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func TestAccAWSRedshiftServiceAccount_basic(t *testing.T) {
resource.TestStep{
Config: testAccCheckAwsRedshiftServiceAccountExplicitRegionConfig,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.aws_redshift_service_account.regional", "id", "210876761215"),
resource.TestCheckResourceAttr("data.aws_redshift_service_account.regional", "id", "307160386991"),
),
},
},
Expand All @@ -33,6 +33,6 @@ data "aws_redshift_service_account" "main" { }

const testAccCheckAwsRedshiftServiceAccountExplicitRegionConfig = `
data "aws_redshift_service_account" "regional" {
region = "eu-west-1"
region = "eu-west-2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to change this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly not - I'm new to updating the terraform source code

I thought it would help validate the new Redshift service account (eu-west-2) being added - remove if not required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, was just wondering :)

}
`