-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/networkfirewall_rule_group: remove ForceNew attribute from stateful_rule field and its children #16884
resource/networkfirewall_rule_group: remove ForceNew attribute from stateful_rule field and its children #16884
Conversation
de54139
to
4ae1710
Compare
4ae1710
to
ceb99cd
Compare
aa7cf8f
to
c8afb45
Compare
c8afb45
to
8123e8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule (135.81s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rules (138.40s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_disappears (143.02s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction (144.81s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule (145.31s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList (149.00s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList (174.29s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule (176.54s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule (176.71s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_header (178.76s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_tags (186.58s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules (189.97s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_action (191.41s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (198.54s)
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #16868
Release note for CHANGELOG:
Output from acceptance testing: