Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/networkfirewall_rule_group: remove ForceNew attribute from stateful_rule field and its children #16884

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16868

Release note for CHANGELOG:

resource/networkfirewall_rule_group: remove ForceNew attribute from stateful_rule configuration block

Output from acceptance testing:

--- PASS: TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction (137.23s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule (138.48s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule (138.70s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_disappears (143.01s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rules (143.92s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList (148.03s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList (176.74s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_header (177.97s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule (178.11s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule (178.50s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (186.76s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_action (190.40s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_tags (198.29s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules (198.92s)

@anGie44 anGie44 requested a review from a team as a code owner December 23, 2020 01:41
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. labels Dec 23, 2020
@anGie44 anGie44 force-pushed the b-networkfirewall-rule-group-remove-forcenew-from-stateful-rule-fields branch from de54139 to 4ae1710 Compare December 23, 2020 02:06
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 23, 2020
@anGie44 anGie44 force-pushed the b-networkfirewall-rule-group-remove-forcenew-from-stateful-rule-fields branch from 4ae1710 to ceb99cd Compare December 23, 2020 02:34
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 23, 2020
@anGie44 anGie44 force-pushed the b-networkfirewall-rule-group-remove-forcenew-from-stateful-rule-fields branch 2 times, most recently from aa7cf8f to c8afb45 Compare December 23, 2020 02:55
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Dec 23, 2020
@anGie44 anGie44 force-pushed the b-networkfirewall-rule-group-remove-forcenew-from-stateful-rule-fields branch from c8afb45 to 8123e8e Compare December 23, 2020 03:10
@gdavison gdavison self-assigned this Jan 7, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule (135.81s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rules (138.40s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_disappears (143.02s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction (144.81s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule (145.31s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList (149.00s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList (174.29s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule (176.54s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule (176.71s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_header (178.76s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_tags (186.58s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules (189.97s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_action (191.41s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (198.54s)

@anGie44 anGie44 added this to the v3.24.0 milestone Jan 11, 2021
@anGie44 anGie44 merged commit 339584d into master Jan 11, 2021
@anGie44 anGie44 deleted the b-networkfirewall-rule-group-remove-forcenew-from-stateful-rule-fields branch January 11, 2021 21:40
anGie44 added a commit that referenced this pull request Jan 11, 2021
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_networkfirewall_rule_group unnecessary replacement
2 participants