resource/aws_lb_target_group: Prevent eventual consistency related tagging errors on creation #17280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
github-actions
bot
added
the
needs-triage
|
@shuheiktgw Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider! |
YakDriver
removed
the
needs-triage
YakDriver
force-pushed
the
target_group-tags
branch
from
5e7e6ea
to
c543e45
Compare
ghost
added
size/S
YakDriver
force-pushed
the
target_group-tags
branch
from
9c8c5b1
to
34188a4
Compare
ghost
added
size/M
YakDriver
force-pushed
the
target_group-tags
branch
from
df729bf
to
7ef9014
Compare
YakDriver
force-pushed
the
target_group-tags
branch
from
7ef9014
to
7b5ebb2
Compare
YakDriver
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Looks great! 🎉
GovCloud acceptance testing:
--- PASS: TestAccAWSLB_ALB_AccessLogs (371.03s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (314.26s)
--- PASS: TestAccAWSLB_ALB_basic (180.51s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (292.10s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (291.56s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (281.35s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (188.45s)
--- PASS: TestAccAWSLB_generatedName (189.03s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (182.34s)
--- PASS: TestAccAWSLB_IPv6SubnetMapping (247.36s)
--- PASS: TestAccAWSLB_namePrefix (190.51s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (262.82s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (330.22s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (222.45s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (437.93s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (375.61s)
--- PASS: TestAccAWSLB_NLB_basic (270.43s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (219.38s)
--- PASS: TestAccAWSLB_noSecurityGroup (180.11s)
--- PASS: TestAccAWSLB_tags (317.13s)
--- PASS: TestAccAWSLB_updatedIpAddressType (254.59s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (240.48s)
--- PASS: TestAccAWSLB_updatedSubnets (260.89s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (33.26s)
--- PASS: TestAccAWSLBTargetGroup_basic (54.81s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (30.82s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (84.45s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (57.53s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (60.35s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (57.65s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (48.80s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (63.11s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (34.87s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (28.37s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (28.19s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (95.97s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (56.12s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (59.36s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (25.57s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (30.03s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (28.46s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (50.68s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (47.78s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (105.66s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (70.67s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (54.29s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (73.77s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (149.07s)
--- PASS: TestAccAWSLBTargetGroup_tags (81.20s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (54.70s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (59.76s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (100.90s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (19.23s)
--- SKIP: TestAccAWSLB_ALB_outpost (0.75s)
--- SKIP: TestAccAWSLB_LoadBalancerType_Gateway (1.89s)
--- SKIP: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (1.65s)
--- SKIP: TestAccAWSLBTargetGroup_Protocol_Geneve (0.33s)
us-west-2:
--- PASS: TestAccAWSLB_ALB_AccessLogs (364.16s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (416.02s)
--- PASS: TestAccAWSLB_ALB_basic (294.54s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (363.18s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (360.14s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (379.70s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (259.80s)
--- PASS: TestAccAWSLB_generatedName (265.82s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (243.13s)
--- PASS: TestAccAWSLB_IPv6SubnetMapping (319.49s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway (167.38s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (183.37s)
--- PASS: TestAccAWSLB_namePrefix (262.22s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (218.10s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (227.19s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (361.62s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (420.23s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (363.67s)
--- PASS: TestAccAWSLB_NLB_basic (258.65s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (229.84s)
--- PASS: TestAccAWSLB_noSecurityGroup (185.20s)
--- PASS: TestAccAWSLB_tags (422.13s)
--- PASS: TestAccAWSLB_updatedIpAddressType (239.22s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (246.73s)
--- PASS: TestAccAWSLB_updatedSubnets (244.98s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (27.56s)
--- PASS: TestAccAWSLBTargetGroup_basic (76.80s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (26.65s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (51.46s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (52.04s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (54.66s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (52.89s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (27.22s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (70.42s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (28.61s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (26.18s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (24.99s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (82.91s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (48.68s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (24.37s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (54.28s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (21.45s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (26.91s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (26.12s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (43.56s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (24.44s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (71.19s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (75.84s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (72.36s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (100.46s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (113.50s)
--- PASS: TestAccAWSLBTargetGroup_tags (72.75s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (48.93s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (55.06s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (70.10s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (14.33s)
--- SKIP: TestAccAWSLB_ALB_outpost (1.34s)
|
Thank you! |
|
This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
Thank you for your review and modification! @YakDriver |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #16860
Output from acceptance testing:
As I wrote in the issue, I myself could not reproduce the problem locally. However, many people seem to experience it so I added a retry mechanism to adding tags following #12738. Thank you for your review!