Clarify that overriding policy document statements can be added to current document if sid does not match

[aperiodic]

In the description of iam_policy_document data source's
override_json argument, state specifically that any statements in the
override document that have sids that do not match a statement in
the current document will be added to the current document, instead of
ignored. Before this change, there was no description of how
non-matching statements in the override_json were used, so the
behavior was unclear: the opposite and incorrect conclusion that these
statements were ignored was equally consistent with the documentation.

This behavior is covered by an acceptance test, so from the coverage I'm
inferring that this behavior is both intended and supported.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

I am omitting the output from acceptance testing, because this is a documentation-only change.

[github-actions]

Welcome @aperiodic 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@aperiodic Thank you for noticing this hole in the documentation and taking the initiative to fill it! 🎉 This builds on a fairly extensive overhaul of the aws_iam_policy_document documentation in #12055.

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!