Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change detection relating to vpc_config #17610

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Fix change detection relating to vpc_config #17610

merged 3 commits into from
Jun 4, 2021

Commits on Mar 27, 2021

  1. Fix change detection relating to vpc_config 

    As reported in #17385
a change i  detected in vpc_config when there are no changes, this is
caused by an issue in hashicorp/terraform-plugin-sdk#617
The PR to provide a fix is not getting any traction.

On further debuging the issue is caused by the nested elements being of
type set which needs the use of Equal rather than reflect.DeepEqual to
test for differences.

We can work around this bug by testing for changes in the two fields
within vpc_config independantly as when the item passed to HasChanges is
a Set it is tested correctly.
    @grahamhar
    grahamhar committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    82ff95d View commit details
    Browse the repository at this point in the history

  2. Add acceptance tests

    @grahamhar
    grahamhar committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    ee8fb45 View commit details
    Browse the repository at this point in the history

  3. Refactor test to work around ENI deletion issue 

    Removing the VPC config is still a valid vpc config change and works
around the ENI deltion issue.
    @grahamhar
    grahamhar committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    622a2f4 View commit details
    Browse the repository at this point in the history