Include tags in options for creating vpc EIPs.

[rick-masters]

My first contribution to terraform. I will be able to finish my tag-based security strategy with this feature.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16881

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSEIP" ACCTEST_PARALLELISM=1                                    
==> Checking that code complies with gofmt requirements...                                                                                         
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSEIP -timeout 120m
=== RUN   TestAccAWSEIPAssociation_instance                                                                                                        
=== PAUSE TestAccAWSEIPAssociation_instance                                                                                                        
=== RUN   TestAccAWSEIPAssociation_networkInterface                      
=== PAUSE TestAccAWSEIPAssociation_networkInterface                      
=== RUN   TestAccAWSEIPAssociation_basic                                                                                                           
=== PAUSE TestAccAWSEIPAssociation_basic                                                                                                           
=== RUN   TestAccAWSEIPAssociation_ec2Classic                                                                                                      
=== PAUSE TestAccAWSEIPAssociation_ec2Classic                                                                                                      
=== RUN   TestAccAWSEIPAssociation_spotInstance                                                                                                    
=== PAUSE TestAccAWSEIPAssociation_spotInstance                                                                                                    
=== RUN   TestAccAWSEIPAssociation_disappears                                                                                                      
=== PAUSE TestAccAWSEIPAssociation_disappears                                                                                                      
=== RUN   TestAccAWSEIP_Ec2Classic                                                                                                                 
=== PAUSE TestAccAWSEIP_Ec2Classic                                                                                                                 
=== RUN   TestAccAWSEIP_basic                                                                                                                      
=== PAUSE TestAccAWSEIP_basic                                                                                                                      
=== RUN   TestAccAWSEIP_instance                                                                                                                   
=== PAUSE TestAccAWSEIP_instance                                         
=== RUN   TestAccAWSEIP_networkInterface                                                                                                           
=== PAUSE TestAccAWSEIP_networkInterface        
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface                                                                                                 
=== PAUSE TestAccAWSEIP_twoEIPsOneNetworkInterface                       
=== RUN   TestAccAWSEIP_associated_user_private_ip                       
=== PAUSE TestAccAWSEIP_associated_user_private_ip                       
=== RUN   TestAccAWSEIP_Instance_Reassociate                     
=== PAUSE TestAccAWSEIP_Instance_Reassociate                             
=== RUN   TestAccAWSEIP_disappears                                                                                                                 
=== PAUSE TestAccAWSEIP_disappears                                                                                                                 
=== RUN   TestAccAWSEIP_notAssociated                                                                                                              
=== PAUSE TestAccAWSEIP_notAssociated                                    
=== RUN   TestAccAWSEIP_tags_Vpc                                                                                                                   
=== PAUSE TestAccAWSEIP_tags_Vpc
=== RUN   TestAccAWSEIP_tags_Ec2Classic
=== PAUSE TestAccAWSEIP_tags_Ec2Classic
=== RUN   TestAccAWSEIP_PublicIpv4Pool_default
=== PAUSE TestAccAWSEIP_PublicIpv4Pool_default
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== RUN   TestAccAWSEIP_CarrierIP
=== PAUSE TestAccAWSEIP_CarrierIP
=== RUN   TestAccAWSEIP_PublicIpv4Pool_custom
    resource_aws_eip_test.go:501: Environment variable AWS_EC2_EIP_PUBLIC_IPV4_POOL is not set
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
=== RUN   TestAccAWSEIP_CustomerOwnedIpv4Pool
=== PAUSE TestAccAWSEIP_CustomerOwnedIpv4Pool
=== CONT  TestAccAWSEIPAssociation_instance
--- PASS: TestAccAWSEIPAssociation_instance (308.11s)
=== CONT  TestAccAWSEIP_CustomerOwnedIpv4Pool
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (0.31s)
=== CONT  TestAccAWSEIP_CarrierIP
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEIP_CarrierIP (0.04s)
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (15.03s)
=== CONT  TestAccAWSEIP_PublicIpv4Pool_default
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (15.22s)
=== CONT  TestAccAWSEIP_tags_Ec2Classic
--- PASS: TestAccAWSEIP_tags_Ec2Classic (9.90s)
=== CONT  TestAccAWSEIP_tags_Vpc
--- PASS: TestAccAWSEIP_tags_Vpc (23.58s)
=== CONT  TestAccAWSEIP_notAssociated
--- PASS: TestAccAWSEIP_notAssociated (108.03s)
=== CONT  TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (10.51s)
=== CONT  TestAccAWSEIP_Instance_Reassociate
--- PASS: TestAccAWSEIP_Instance_Reassociate (111.42s)
=== CONT  TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (474.32s)
=== CONT  TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (60.54s)
=== CONT  TestAccAWSEIP_networkInterface
--- PASS: TestAccAWSEIP_networkInterface (60.00s)
=== CONT  TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (318.70s)
=== CONT  TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (15.22s)
=== CONT  TestAccAWSEIP_Ec2Classic
--- PASS: TestAccAWSEIP_Ec2Classic (234.35s)
=== CONT  TestAccAWSEIPAssociation_disappears
--- PASS: TestAccAWSEIPAssociation_disappears (113.78s)
=== CONT  TestAccAWSEIPAssociation_spotInstance
--- PASS: TestAccAWSEIPAssociation_spotInstance (96.22s)
=== CONT  TestAccAWSEIPAssociation_ec2Classic
--- PASS: TestAccAWSEIPAssociation_ec2Classic (96.23s)
=== CONT  TestAccAWSEIPAssociation_basic
    provider_test.go:714: This test can only in regions without EC2 Classic, platforms available in us-west-2: ["EC2" "VPC"]
--- SKIP: TestAccAWSEIPAssociation_basic (0.00s)
=== CONT  TestAccAWSEIPAssociation_networkInterface
--- PASS: TestAccAWSEIPAssociation_networkInterface (57.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2129.584s

[github-actions]

Welcome @rick-masters 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[gdavison]

Looks good 🚀

Acceptance test results

--- PASS: TestAccAWSEIP_tags_Ec2Classic (30.19s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (0.91s)
--- PASS: TestAccAWSEIP_disappears (33.42s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (41.18s)
--- PASS: TestAccAWSEIP_CarrierIP (42.37s)
--- PASS: TestAccAWSEIP_basic (43.68s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (44.01s)
--- PASS: TestAccAWSEIP_tags_Vpc (52.58s)
--- PASS: TestAccAWSEIP_instance (80.14s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (81.00s)
--- PASS: TestAccAWSEIP_networkInterface (83.54s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (83.92s)
--- PASS: TestAccAWSEIPAssociation_instance (89.55s)
--- PASS: TestAccAWSEIPAssociation_disappears (113.91s)
--- PASS: TestAccAWSEIP_notAssociated (115.16s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (140.40s)
--- PASS: TestAccAWSEIPAssociation_basic (181.56s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (240.00s)
--- PASS: TestAccAWSEIP_Ec2Classic (266.40s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (334.06s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (349.30s)

[ghost]

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!