Sweeper: exclude replication group member clusters from aws_elasticache_cluster sweeper #17650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
anGie44
approved these changes
Feb 17, 2021
Comment on lines
57
to
60
| if tfawserr.ErrMessageContains(err, elasticache.ErrCodeInvalidCacheClusterStateFault, "only member of a replication group") { | ||
| log.Printf("[WARN] ElastiCache Cache Cluster (%s) is member of a Replication Group. Ignoring. %s", id, err) | ||
| continue | ||
| } |
There was a problem hiding this comment.
qq: if we're filtering these specific clusters out in the DescribeCacheClustersInput , is it still possible to hit this type of error? doesn't hurt to catch the error tho 👍
There was a problem hiding this comment.
Good catch, it's redundant since they're filtered out from the results
There was a problem hiding this comment.
gotchu, sounds good! tho i'm always cautious with AWS APIs 😅
heitorlessa
added a commit
to heitorlessa/terraform-provider-aws
that referenced
this pull request
Feb 18, 2021
…r-aws into main * 'main' of https://github.com/hashicorp/terraform-provider-aws: (599 commits) Adds CHANGELOG Updates acceptance tests and documentation Update CHANGELOG.md for hashicorp#17650 Removes redundant error check Update CHANGELOG.md for hashicorp#17645 resource/aws_lb_listener_certificate: Prevent resource ID parsing error with IAM Server Certificate names containing underscores (hashicorp#17645) resource/aws_instance: Apply attribute waiter logic to iam_instance_profile attribute (hashicorp#17414) Update CHANGELOG.md for hashicorp#17534 Adds multi-error handling to ElastiCache Cluster sweeper Excludes Clusters in Replication Groups from sweeper Adds check for deleting only member of replication group and does not retry Update CHANGELOG.md for hashicorp#17204 Update docs for cloudfront_distribution resource fix(aws_ses_reciept_rule): include period in name validation regex Add CHANGELOG entry. r/aws_dx_gateway_association: Fix 'TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount'. r/aws_ec2_transit_gateway: Increase deletion IncorrectState retry to 5 minutes. Update CHANGELOG.md after release fix if evaluation r/aws_dx_gateway_association: Modernize acceptance tests. ...
heitorlessa
added a commit
to heitorlessa/terraform-provider-aws
that referenced
this pull request
Feb 18, 2021
* main: (599 commits) Adds CHANGELOG Updates acceptance tests and documentation Update CHANGELOG.md for hashicorp#17650 Removes redundant error check Update CHANGELOG.md for hashicorp#17645 resource/aws_lb_listener_certificate: Prevent resource ID parsing error with IAM Server Certificate names containing underscores (hashicorp#17645) resource/aws_instance: Apply attribute waiter logic to iam_instance_profile attribute (hashicorp#17414) Update CHANGELOG.md for hashicorp#17534 Adds multi-error handling to ElastiCache Cluster sweeper Excludes Clusters in Replication Groups from sweeper Adds check for deleting only member of replication group and does not retry Update CHANGELOG.md for hashicorp#17204 Update docs for cloudfront_distribution resource fix(aws_ses_reciept_rule): include period in name validation regex Add CHANGELOG entry. r/aws_dx_gateway_association: Fix 'TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount'. r/aws_ec2_transit_gateway: Increase deletion IncorrectState retry to 5 minutes. Update CHANGELOG.md after release fix if evaluation r/aws_dx_gateway_association: Modernize acceptance tests. ...
|
This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents retry when trying to delete the last member cluster from a replication group.
Excludes replication group member clusters from sweeper.
Closes #17647