Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/fms_policy: update example usage with jsonencode #17717

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17714
Relates #17710

Output from acceptance testing:

N/A

Notes

  • managed_service_data config block section removed as it does not match the argument data type i.e. String but instead moved the example link to the argument definition

@anGie44 anGie44 requested a review from a team as a code owner February 19, 2021 19:24
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. labels Feb 19, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@anGie44 anGie44 added this to the v3.30.0 milestone Feb 19, 2021
@anGie44 anGie44 merged commit a08c524 into main Feb 19, 2021
@anGie44 anGie44 deleted the d-fms-policy-example-usage branch February 19, 2021 21:29
github-actions bot pushed a commit that referenced this pull request Feb 19, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants