-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Add labels, colors #17807
github: Add labels, colors #17807
Conversation
@@ -1,15 +1,50 @@ | |||
variable "workflow_labels" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only concern is that some of the more urgent labels (bug/regression/crash) and (needs-triage) seem to blend in quite easily with the less urgent (documentation) so glancing over the issue list requires more 👀 ...or could just be my screen brightness 😅 i do feel though that "proposal" should get its own color as it's rare/lives in a different category imo to "documentation"
"regression" = "f04e54", | ||
"waiting-response" = "ef4349", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some label organizing...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YakDriver i think let's get this one so we have the labels correctly tracked? (modifications can be addressed later if they're not working for us; afict no hay ningún problema 👍) ..also looks like just a go mod check failure to address atm
This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Adds labels to workflow that were previously not captured. Aligns label colors with HashiCorp's color schemes for applications.
Output from acceptance testing:
Update: Since submitting this PR, HashiCorp has changed colors slightly. The colors listed in this comment are not accurate. They are correct in the PR itself.
Uses these groupings:
623ce4
- Terraform Purpleservice
provider
491dd7
- Darker Terraform Purplepartition/aws-us-gov
partition/aws-iso-b
partition/aws-cn
partition/aws-iso
ca2171
- Consul Pinkneeds-triage
962fab
enhancement
new-resource
new-data-source
f04e54
- Boundary Redbug
crash
breaking-change
regression
ef4349
- Darker Boundary Redwaiting-response
00bc7f
- Nomad Greentests
terraform-0.15
terraform-0.14
terraform-0.11
terraform-0.12
alpha-testing
b0288e
documentation
technical-debt
proposal
thinking
question
linter
14c6cb
- Waypoint Turquoisesize/XS
size/XL
size/L
size/M
size/S
size/XXL
1563ff
- HashiCorp (& Vagrant) Blueupstream-terraform
upstream
go
dependencies
00acff
- Packer Bluegood first issue
help wanted
examples
828a90
stale
hashibot/ignore
new
windows
reinvent
hacktoberfest
github_actions