Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Refactoring for Go 1.16 ioutil package deprecation #17822

Merged
merged 1 commit into from
Mar 8, 2021
Merged

provider: Refactoring for Go 1.16 ioutil package deprecation #17822

merged 1 commit into from
Mar 8, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://golang.org/doc/go1.16#ioutil
Closes #17685

The io/ioutil package has turned out to be a poorly defined and hard to understand collection of things. All functionality provided by the package has been moved to other packages. The io/ioutil package remains and will continue to work as before, but we encourage new code to use the new definitions in the io and os packages. Here is a list of the new locations of the names exported by io/ioutil:

Discard => io.Discard
NopCloser => io.NopCloser
ReadAll => io.ReadAll
ReadDir => os.ReadDir (note: returns a slice of os.DirEntry rather than a slice of fs.FileInfo)
ReadFile => os.ReadFile
TempDir => os.MkdirTemp
TempFile => os.CreateTemp
WriteFile => os.WriteFile

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEksClusterAuthDataSource_basic (22.94s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (397.35s)
--- PASS: TestAccAWSEMRCluster_basic (417.79s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1219.90s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (712.72s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (554.33s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1053.30s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (502.10s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (930.50s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (874.76s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (561.57s)
--- PASS: TestAccAWSEMRCluster_disappears (411.63s)
--- PASS: TestAccAWSEMRCluster_ebs_config (468.45s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (855.75s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (541.93s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (456.74s)
--- PASS: TestAccAWSEMRCluster_keepJob (427.24s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (419.55s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (982.40s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1108.12s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (796.95s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (824.90s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (858.33s)
--- PASS: TestAccAWSEMRCluster_s3Logging (530.64s)
--- PASS: TestAccAWSEMRCluster_security_config (488.98s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (418.55s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (468.54s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (867.38s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (429.61s)
--- PASS: TestAccAWSEMRCluster_tags (778.27s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (466.76s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (681.14s)

--- PASS: TestAccAWSIPRanges_basic (8.32s)
--- PASS: TestAccAWSIPRanges_Url (8.11s)

--- PASS: TestAccAWSLambdaFunction_basic (834.98s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1041.09s)
--- PASS: TestAccAWSLambdaFunction_concurrency (61.96s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (833.61s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (723.36s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (825.62s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (1030.44s)
--- PASS: TestAccAWSLambdaFunction_disappears (987.71s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (248.82s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (1061.19s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (1032.39s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (829.61s)
--- PASS: TestAccAWSLambdaFunction_envVariables (897.91s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (15.36s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (2800.62s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (375.38s)
--- PASS: TestAccAWSLambdaFunction_Layers (382.02s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (409.94s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (1230.66s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (273.09s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (1054.40s)
--- PASS: TestAccAWSLambdaFunction_runtimes (488.91s)
--- PASS: TestAccAWSLambdaFunction_s3 (58.10s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (101.92s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (100.67s)
--- PASS: TestAccAWSLambdaFunction_tags (136.46s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (403.51s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (865.58s)
--- PASS: TestAccAWSLambdaFunction_versioned (80.38s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1180.44s)
--- PASS: TestAccAWSLambdaFunction_VPC (404.37s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (897.65s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (746.66s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (288.91s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2372.42s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)

--- PASS: TestAccAWSS3BucketObject_acl (118.19s)
--- PASS: TestAccAWSS3BucketObject_content (34.71s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (46.29s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (52.28s)
--- PASS: TestAccAWSS3BucketObject_empty (46.48s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.17s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (86.02s)
--- PASS: TestAccAWSS3BucketObject_kms (47.67s)
--- PASS: TestAccAWSS3BucketObject_metadata (116.27s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (8.51s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (109.88s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (86.04s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (75.78s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (133.43s)
--- PASS: TestAccAWSS3BucketObject_source (44.71s)
--- PASS: TestAccAWSS3BucketObject_sse (43.06s)
--- PASS: TestAccAWSS3BucketObject_storageClass (107.25s)
--- PASS: TestAccAWSS3BucketObject_tags (120.07s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (147.00s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (118.44s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (129.75s)
--- PASS: TestAccAWSS3BucketObject_updates (86.05s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (56.79s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (55.94s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (54.03s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (47.14s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.70s)

--- PASS: TestAccAWSUser_basic (18.29s)
--- PASS: TestAccAWSUser_disappears (7.90s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (11.06s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (19.05s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (11.01s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (11.95s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (10.68s)
--- PASS: TestAccAWSUser_nameChange (16.99s)
--- PASS: TestAccAWSUser_pathChange (17.62s)
--- PASS: TestAccAWSUser_permissionsBoundary (39.55s)
--- PASS: TestAccAWSUser_tags (17.68s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEksClusterAuthDataSource_basic (28.16s)

--- FAIL: TestAccAWSEMRCluster_bootstrap_ordering (264.97s) # https://github.com/hashicorp/terraform-provider-aws/issues/15608
--- FAIL: TestAccAWSEMRCluster_instance_fleet (309.15s) # https://github.com/hashicorp/terraform-provider-aws/issues/15608
--- FAIL: TestAccAWSEMRCluster_instance_fleet_master_only (291.43s) # https://github.com/hashicorp/terraform-provider-aws/issues/15608
--- PASS: TestAccAWSEMRCluster_additionalInfo (425.04s)
--- PASS: TestAccAWSEMRCluster_basic (356.09s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (370.54s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (563.88s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (867.74s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (497.50s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (826.05s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (759.99s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (434.39s)
--- PASS: TestAccAWSEMRCluster_disappears (478.53s)
--- PASS: TestAccAWSEMRCluster_ebs_config (458.88s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (759.17s)
--- PASS: TestAccAWSEMRCluster_keepJob (362.22s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (387.79s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (715.21s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1181.25s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (725.58s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (796.99s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (729.93s)
--- PASS: TestAccAWSEMRCluster_s3Logging (518.49s)
--- PASS: TestAccAWSEMRCluster_security_config (453.30s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (387.80s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (424.42s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (865.86s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (395.99s)
--- PASS: TestAccAWSEMRCluster_tags (708.44s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (356.26s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (675.16s)

--- PASS: TestAccAWSIPRanges_basic (12.75s)
--- PASS: TestAccAWSIPRanges_Url (12.92s)

--- PASS: TestAccAWSLambdaFunction_basic (68.18s)
--- PASS: TestAccAWSLambdaFunction_concurrency (107.17s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (156.84s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (131.64s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (132.90s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (157.57s)
--- PASS: TestAccAWSLambdaFunction_disappears (70.26s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (143.29s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (151.67s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (133.97s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (75.02s)
--- PASS: TestAccAWSLambdaFunction_envVariables (193.79s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (35.54s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (827.55s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (156.53s)
--- PASS: TestAccAWSLambdaFunction_Layers (155.57s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (214.20s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (523.98s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (529.79s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (109.03s)
--- PASS: TestAccAWSLambdaFunction_runtimes (580.88s)
--- PASS: TestAccAWSLambdaFunction_s3 (35.21s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (60.72s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (61.89s)
--- PASS: TestAccAWSLambdaFunction_tags (199.60s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (97.62s)
--- PASS: TestAccAWSLambdaFunction_versioned (111.62s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (205.20s)
--- PASS: TestAccAWSLambdaFunction_VPC (386.34s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (553.55s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (256.43s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (383.17s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1930.81s)
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.75s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)

--- PASS: TestAccAWSS3BucketObject_acl (78.44s)
--- PASS: TestAccAWSS3BucketObject_content (47.36s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (47.06s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (40.35s)
--- PASS: TestAccAWSS3BucketObject_empty (47.45s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (47.13s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (69.26s)
--- PASS: TestAccAWSS3BucketObject_kms (31.34s)
--- PASS: TestAccAWSS3BucketObject_metadata (113.98s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.18s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (115.61s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (77.40s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (114.51s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (139.11s)
--- PASS: TestAccAWSS3BucketObject_source (47.21s)
--- PASS: TestAccAWSS3BucketObject_sse (29.40s)
--- PASS: TestAccAWSS3BucketObject_storageClass (161.13s)
--- PASS: TestAccAWSS3BucketObject_tags (158.09s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (162.01s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (162.35s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (161.07s)
--- PASS: TestAccAWSS3BucketObject_updates (93.23s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (52.71s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (52.29s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (56.95s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (46.56s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (1.58s)

--- PASS: TestAccAWSUser_basic (30.14s)
--- PASS: TestAccAWSUser_disappears (11.79s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (19.10s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (18.86s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (19.94s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (20.78s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (19.72s)
--- PASS: TestAccAWSUser_nameChange (28.31s)
--- PASS: TestAccAWSUser_pathChange (48.94s)
--- PASS: TestAccAWSUser_permissionsBoundary (100.25s)
--- PASS: TestAccAWSUser_tags (68.49s)

@bflad
provider: Refactoring for Go 1.16 ioutil package deprecation
bcdd3fc 
Reference: https://golang.org/doc/go1.16#ioutil
Reference: #17685

> The io/ioutil package has turned out to be a poorly defined and hard to understand collection of things. All functionality provided by the package has been moved to other packages. The io/ioutil package remains and will continue to work as before, but we encourage new code to use the new definitions in the io and os packages. Here is a list of the new locations of the names exported by io/ioutil:
>
> Discard => io.Discard
> NopCloser => io.NopCloser
> ReadAll => io.ReadAll
> ReadDir => os.ReadDir (note: returns a slice of os.DirEntry rather than a slice of fs.FileInfo)
> ReadFile => os.ReadFile
> TempDir => os.MkdirTemp
> TempFile => os.CreateTemp
> WriteFile => os.WriteFile

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSEksClusterAuthDataSource_basic (22.94s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (397.35s)
--- PASS: TestAccAWSEMRCluster_basic (417.79s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1219.90s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (712.72s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (554.33s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1053.30s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (502.10s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (930.50s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (874.76s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (561.57s)
--- PASS: TestAccAWSEMRCluster_disappears (411.63s)
--- PASS: TestAccAWSEMRCluster_ebs_config (468.45s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (855.75s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (541.93s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (456.74s)
--- PASS: TestAccAWSEMRCluster_keepJob (427.24s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (419.55s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (982.40s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1108.12s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (796.95s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (824.90s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (858.33s)
--- PASS: TestAccAWSEMRCluster_s3Logging (530.64s)
--- PASS: TestAccAWSEMRCluster_security_config (488.98s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (418.55s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (468.54s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (867.38s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (429.61s)
--- PASS: TestAccAWSEMRCluster_tags (778.27s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (466.76s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (681.14s)

--- PASS: TestAccAWSIPRanges_basic (8.32s)
--- PASS: TestAccAWSIPRanges_Url (8.11s)

--- PASS: TestAccAWSLambdaFunction_basic (834.98s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1041.09s)
--- PASS: TestAccAWSLambdaFunction_concurrency (61.96s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (833.61s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (723.36s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (825.62s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (1030.44s)
--- PASS: TestAccAWSLambdaFunction_disappears (987.71s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (248.82s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (1061.19s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (1032.39s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (829.61s)
--- PASS: TestAccAWSLambdaFunction_envVariables (897.91s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (15.36s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (2800.62s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (375.38s)
--- PASS: TestAccAWSLambdaFunction_Layers (382.02s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (409.94s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (1230.66s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (273.09s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (1054.40s)
--- PASS: TestAccAWSLambdaFunction_runtimes (488.91s)
--- PASS: TestAccAWSLambdaFunction_s3 (58.10s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (101.92s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (100.67s)
--- PASS: TestAccAWSLambdaFunction_tags (136.46s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (403.51s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (865.58s)
--- PASS: TestAccAWSLambdaFunction_versioned (80.38s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1180.44s)
--- PASS: TestAccAWSLambdaFunction_VPC (404.37s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (897.65s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (746.66s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (288.91s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2372.42s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)

--- PASS: TestAccAWSS3BucketObject_acl (118.19s)
--- PASS: TestAccAWSS3BucketObject_content (34.71s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (46.29s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (52.28s)
--- PASS: TestAccAWSS3BucketObject_empty (46.48s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.17s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (86.02s)
--- PASS: TestAccAWSS3BucketObject_kms (47.67s)
--- PASS: TestAccAWSS3BucketObject_metadata (116.27s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (8.51s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (109.88s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (86.04s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (75.78s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (133.43s)
--- PASS: TestAccAWSS3BucketObject_source (44.71s)
--- PASS: TestAccAWSS3BucketObject_sse (43.06s)
--- PASS: TestAccAWSS3BucketObject_storageClass (107.25s)
--- PASS: TestAccAWSS3BucketObject_tags (120.07s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (147.00s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (118.44s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (129.75s)
--- PASS: TestAccAWSS3BucketObject_updates (86.05s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (56.79s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (55.94s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (54.03s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (47.14s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.70s)

--- PASS: TestAccAWSUser_basic (18.29s)
--- PASS: TestAccAWSUser_disappears (7.90s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (11.06s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (19.05s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (11.01s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (11.95s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (10.68s)
--- PASS: TestAccAWSUser_nameChange (16.99s)
--- PASS: TestAccAWSUser_pathChange (17.62s)
--- PASS: TestAccAWSUser_permissionsBoundary (39.55s)
--- PASS: TestAccAWSUser_tags (17.68s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSEksClusterAuthDataSource_basic (28.16s)

--- FAIL: TestAccAWSEMRCluster_bootstrap_ordering (264.97s) # #15608
--- FAIL: TestAccAWSEMRCluster_instance_fleet (309.15s) # #15608
--- FAIL: TestAccAWSEMRCluster_instance_fleet_master_only (291.43s) # #15608
--- PASS: TestAccAWSEMRCluster_additionalInfo (425.04s)
--- PASS: TestAccAWSEMRCluster_basic (356.09s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (370.54s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (563.88s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (867.74s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (497.50s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (826.05s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (759.99s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (434.39s)
--- PASS: TestAccAWSEMRCluster_disappears (478.53s)
--- PASS: TestAccAWSEMRCluster_ebs_config (458.88s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (759.17s)
--- PASS: TestAccAWSEMRCluster_keepJob (362.22s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (387.79s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (715.21s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1181.25s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (725.58s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (796.99s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (729.93s)
--- PASS: TestAccAWSEMRCluster_s3Logging (518.49s)
--- PASS: TestAccAWSEMRCluster_security_config (453.30s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (387.80s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (424.42s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (865.86s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (395.99s)
--- PASS: TestAccAWSEMRCluster_tags (708.44s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (356.26s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (675.16s)

--- PASS: TestAccAWSIPRanges_basic (12.75s)
--- PASS: TestAccAWSIPRanges_Url (12.92s)

--- PASS: TestAccAWSLambdaFunction_basic (68.18s)
--- PASS: TestAccAWSLambdaFunction_concurrency (107.17s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (156.84s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (131.64s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (132.90s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (157.57s)
--- PASS: TestAccAWSLambdaFunction_disappears (70.26s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (143.29s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (151.67s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (133.97s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (75.02s)
--- PASS: TestAccAWSLambdaFunction_envVariables (193.79s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (35.54s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (827.55s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (156.53s)
--- PASS: TestAccAWSLambdaFunction_Layers (155.57s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (214.20s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (523.98s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (529.79s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (109.03s)
--- PASS: TestAccAWSLambdaFunction_runtimes (580.88s)
--- PASS: TestAccAWSLambdaFunction_s3 (35.21s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (60.72s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (61.89s)
--- PASS: TestAccAWSLambdaFunction_tags (199.60s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (97.62s)
--- PASS: TestAccAWSLambdaFunction_versioned (111.62s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (205.20s)
--- PASS: TestAccAWSLambdaFunction_VPC (386.34s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (553.55s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (256.43s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (383.17s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1930.81s)
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.75s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)

--- PASS: TestAccAWSS3BucketObject_acl (78.44s)
--- PASS: TestAccAWSS3BucketObject_content (47.36s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (47.06s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (40.35s)
--- PASS: TestAccAWSS3BucketObject_empty (47.45s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (47.13s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (69.26s)
--- PASS: TestAccAWSS3BucketObject_kms (31.34s)
--- PASS: TestAccAWSS3BucketObject_metadata (113.98s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.18s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (115.61s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (77.40s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (114.51s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (139.11s)
--- PASS: TestAccAWSS3BucketObject_source (47.21s)
--- PASS: TestAccAWSS3BucketObject_sse (29.40s)
--- PASS: TestAccAWSS3BucketObject_storageClass (161.13s)
--- PASS: TestAccAWSS3BucketObject_tags (158.09s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (162.01s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (162.35s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (161.07s)
--- PASS: TestAccAWSS3BucketObject_updates (93.23s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (52.71s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (52.29s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (56.95s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (46.56s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (1.58s)

--- PASS: TestAccAWSUser_basic (30.14s)
--- PASS: TestAccAWSUser_disappears (11.79s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (19.10s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (18.86s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (19.94s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (20.78s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (19.72s)
--- PASS: TestAccAWSUser_nameChange (28.31s)
--- PASS: TestAccAWSUser_pathChange (48.94s)
--- PASS: TestAccAWSUser_permissionsBoundary (100.25s)
--- PASS: TestAccAWSUser_tags (68.49s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 25, 2021
@bflad bflad requested a review from a team as a code owner February 25, 2021 16:03
@ghost ghost added size/S Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. service/emr Issues and PRs that pertain to the emr service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 25, 2021
@YakDriver YakDriver self-assigned this Mar 4, 2021
YakDriver
YakDriver approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! 🎉

Acceptance tests on GovCloud:
For failures see #15608


--- FAIL: TestAccAWSEMRCluster_bootstrap_ordering (261.67s)
--- FAIL: TestAccAWSEMRCluster_instance_fleet (312.47s)
--- FAIL: TestAccAWSEMRCluster_instance_fleet_master_only (267.69s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (353.95s)
--- PASS: TestAccAWSEMRCluster_basic (423.46s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (430.67s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (488.63s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (911.26s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (502.69s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (784.08s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (820.54s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (458.98s)
--- PASS: TestAccAWSEMRCluster_disappears (364.20s)
--- PASS: TestAccAWSEMRCluster_ebs_config (530.32s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (753.54s)
--- PASS: TestAccAWSEMRCluster_keepJob (346.25s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (382.07s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (756.05s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1065.75s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (691.82s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (723.93s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (741.07s)
--- PASS: TestAccAWSEMRCluster_s3Logging (547.53s)
--- PASS: TestAccAWSEMRCluster_security_config (402.73s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (385.47s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (447.60s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (841.84s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (387.89s)
--- PASS: TestAccAWSEMRCluster_tags (701.05s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (435.14s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (734.62s)
--- PASS: TestAccAWSIPRanges_basic (19.75s)
--- PASS: TestAccAWSIPRanges_Url (13.20s)
--- PASS: TestAccAWSLambdaFunction_basic (94.17s)
--- PASS: TestAccAWSLambdaFunction_concurrency (236.91s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (89.50s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (64.95s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (61.48s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (71.97s)
--- PASS: TestAccAWSLambdaFunction_disappears (190.49s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (37.87s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (92.71s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (66.63s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (654.89s)
--- PASS: TestAccAWSLambdaFunction_envVariables (728.46s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (16.19s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (772.77s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (62.47s)
--- PASS: TestAccAWSLambdaFunction_Layers (660.84s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (788.00s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (182.86s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (187.86s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (17.11s)
--- PASS: TestAccAWSLambdaFunction_runtimes (443.51s)
--- PASS: TestAccAWSLambdaFunction_s3 (35.49s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (60.73s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (59.58s)
--- PASS: TestAccAWSLambdaFunction_tags (78.65s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (53.71s)
--- PASS: TestAccAWSLambdaFunction_versioned (38.40s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (117.42s)
--- PASS: TestAccAWSLambdaFunction_VPC (781.58s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (652.78s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (310.88s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (661.97s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (895.77s)
--- PASS: TestAccAWSS3BucketObject_acl (86.13s)
--- PASS: TestAccAWSS3BucketObject_content (27.14s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (26.20s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (39.09s)
--- PASS: TestAccAWSS3BucketObject_empty (26.96s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (26.05s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (62.63s)
--- PASS: TestAccAWSS3BucketObject_kms (37.02s)
--- PASS: TestAccAWSS3BucketObject_metadata (79.67s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.77s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (86.84s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (62.11s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (84.48s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (89.62s)
--- PASS: TestAccAWSS3BucketObject_source (27.10s)
--- PASS: TestAccAWSS3BucketObject_sse (35.11s)
--- PASS: TestAccAWSS3BucketObject_storageClass (125.95s)
--- PASS: TestAccAWSS3BucketObject_tags (100.82s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (108.33s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (108.37s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (103.23s)
--- PASS: TestAccAWSS3BucketObject_updates (52.43s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (62.16s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (60.93s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (64.30s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (26.67s)
--- PASS: TestAccAWSUser_basic (26.84s)
--- PASS: TestAccAWSUser_disappears (11.35s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (18.44s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (18.26s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (19.00s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (18.43s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (18.64s)
--- PASS: TestAccAWSUser_nameChange (27.00s)
--- PASS: TestAccAWSUser_pathChange (26.76s)
--- PASS: TestAccAWSUser_permissionsBoundary (62.73s)
--- PASS: TestAccAWSUser_tags (27.70s)
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.51s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)
--- SKIP: TestAccAWSLambdaFunction_tracingConfig (0.00s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.00s)

On us-west-2:

--- PASS: TestAccAWSEMRCluster_additionalInfo (407.77s)
--- PASS: TestAccAWSEMRCluster_basic (441.60s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1272.90s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (409.18s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (488.96s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1021.38s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (1222.26s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (969.92s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (919.44s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (546.17s)
--- PASS: TestAccAWSEMRCluster_disappears (411.89s)
--- PASS: TestAccAWSEMRCluster_ebs_config (445.85s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (787.17s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (469.27s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (469.56s)
--- PASS: TestAccAWSEMRCluster_keepJob (410.44s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (414.25s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (1037.88s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1155.64s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (795.00s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (844.82s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (688.16s)
--- PASS: TestAccAWSEMRCluster_s3Logging (731.72s)
--- PASS: TestAccAWSEMRCluster_security_config (481.05s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (495.60s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (464.08s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (942.67s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (542.72s)
--- PASS: TestAccAWSEMRCluster_tags (756.04s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (463.18s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (1294.43s)
--- PASS: TestAccAWSIPRanges_basic (13.54s)
--- PASS: TestAccAWSIPRanges_Url (8.92s)
--- PASS: TestAccAWSLambdaFunction_basic (819.48s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (841.22s)
--- PASS: TestAccAWSLambdaFunction_concurrency (834.23s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (844.84s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (66.06s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (67.40s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (54.85s)
--- PASS: TestAccAWSLambdaFunction_disappears (807.53s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (53.05s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (68.73s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (79.92s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (798.95s)
--- PASS: TestAccAWSLambdaFunction_envVariables (873.09s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (15.33s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1901.73s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (35.94s)
--- PASS: TestAccAWSLambdaFunction_Layers (228.55s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (1006.60s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (856.92s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (838.77s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (16.42s)
--- PASS: TestAccAWSLambdaFunction_runtimes (405.22s)
--- PASS: TestAccAWSLambdaFunction_s3 (38.79s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (62.82s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (62.04s)
--- PASS: TestAccAWSLambdaFunction_tags (85.20s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (66.19s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (1034.90s)
--- PASS: TestAccAWSLambdaFunction_versioned (48.53s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (84.27s)
--- PASS: TestAccAWSLambdaFunction_VPC (1176.14s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (626.11s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (266.24s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1028.48s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2104.95s)
--- PASS: TestAccAWSS3BucketObject_acl (76.77s)
--- PASS: TestAccAWSS3BucketObject_content (23.11s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (23.20s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (33.90s)
--- PASS: TestAccAWSS3BucketObject_empty (24.43s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (24.66s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (55.14s)
--- PASS: TestAccAWSS3BucketObject_kms (31.79s)
--- PASS: TestAccAWSS3BucketObject_metadata (68.90s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.67s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (77.26s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (54.65s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (76.69s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (95.88s)
--- PASS: TestAccAWSS3BucketObject_source (24.20s)
--- PASS: TestAccAWSS3BucketObject_sse (31.05s)
--- PASS: TestAccAWSS3BucketObject_storageClass (112.17s)
--- PASS: TestAccAWSS3BucketObject_tags (93.90s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (96.76s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (95.50s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (96.42s)
--- PASS: TestAccAWSS3BucketObject_updates (45.41s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (45.72s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (49.01s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (57.03s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (23.45s)
--- PASS: TestAccAWSUser_basic (17.57s)
--- PASS: TestAccAWSUser_disappears (8.30s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (12.36s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (18.95s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (13.50s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (11.31s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (10.88s)
--- PASS: TestAccAWSUser_nameChange (17.19s)
--- PASS: TestAccAWSUser_pathChange (23.85s)
--- PASS: TestAccAWSUser_permissionsBoundary (41.07s)
--- PASS: TestAccAWSUser_tags (17.62s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.00s)

@bflad bflad merged commit b1d7c85 into main Mar 8, 2021
@bflad bflad deleted the td-ioutil-deprecation branch March 8, 2021 18:51
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 8, 2021
github-actions bot pushed a commit that referenced this pull request Mar 8, 2021
Update CHANGELOG.md for #17822
7354703
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 9, 2021
Merged
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. service/emr Issues and PRs that pertain to the emr service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/s3 Issues and PRs that pertain to the s3 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging this pull request may close these issues.

Go 1.16 Upgrade Followup Items
2 participants
@bflad @YakDriver