Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/provider: Attribute headers and byline fixes (A-C resources) #18017

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #15842

Previously:

	* website/docs/r/api_gateway_base_path_mapping.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_gateway_response.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_integration.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_integration_response.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method_response.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method_settings.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/appautoscaling_target.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/autoscaling_attachment.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/autoscaling_lifecycle_hook.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_event_target.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_log_destination_policy.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_log_subscription_filter.html.markdown: error checking file contents: attributes section byline (No extra attributes are exported.) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported."
	* website/docs/r/codebuild_project.html.markdown: error checking file contents: attributes section byline (In addition to the arguments above, the following attributes are exported:) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported."
	* website/docs/r/codecommit_trigger.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cognito_identity_provider.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cognito_user_group.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/config_configuration_recorder_status.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/config_remediation_configuration.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cur_report_definition.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference

Output from acceptance testing: N/A (documentation)

Reference: #15842

Previously:

```
	* website/docs/r/api_gateway_base_path_mapping.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_gateway_response.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_integration.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_integration_response.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method_response.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/api_gateway_method_settings.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/appautoscaling_target.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/autoscaling_attachment.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/autoscaling_lifecycle_hook.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_event_target.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_log_destination_policy.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cloudwatch_log_subscription_filter.html.markdown: error checking file contents: attributes section byline (No extra attributes are exported.) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported."
	* website/docs/r/codebuild_project.html.markdown: error checking file contents: attributes section byline (In addition to the arguments above, the following attributes are exported:) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported."
	* website/docs/r/codecommit_trigger.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cognito_identity_provider.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cognito_user_group.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/config_configuration_recorder_status.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/config_remediation_configuration.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
	* website/docs/r/cur_report_definition.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference
```
@bflad bflad requested a review from a team as a code owner March 10, 2021 13:38
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/applicationautoscaling service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/configservice Issues and PRs that pertain to the configservice service. labels Mar 10, 2021
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@bflad bflad merged commit b3d5ab3 into main Mar 17, 2021
@bflad bflad deleted the d-tfproviderdocs-attributes-a-c branch March 17, 2021 15:03
@ghost
Copy link

ghost commented Apr 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/configservice Issues and PRs that pertain to the configservice service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants