Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/ec2: Add ErrorCheck (Data Source Part 2) #18145

Merged
merged 10 commits into from
Mar 18, 2021
Merged

tests/ec2: Add ErrorCheck (Data Source Part 2) #18145

merged 10 commits into from
Mar 18, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 18, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18175

Output from acceptance testing: NA (Handled through daily test run)

@YakDriver YakDriver requested a review from a team as a code owner March 18, 2021 02:04
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2021
@YakDriver YakDriver mentioned this pull request Mar 18, 2021
Closed
@YakDriver YakDriver added partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. and removed service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 18, 2021
breathingdust
breathingdust approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀
Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_\|TestAccDataSourceAwsEc2CoipPools_\|TestAccAWSEc2InstanceTypeOfferingDataSource_\|TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter\|TestAccDataSourceAwsEc2InstanceType_\|TestAccDataSourceAwsEc2LocalGatewayRouteTable_\|TestAccDataSourceAwsEc2LocalGatewayRouteTables_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_\|TestAccDataSourceAwsEc2CoipPools_\|TestAccAWSEc2InstanceTypeOfferingDataSource_\|TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter\|TestAccDataSourceAwsEc2InstanceType_\|TestAccDataSourceAwsEc2LocalGatewayRouteTable_\|TestAccDataSourceAwsEc2LocalGatewayRouteTables_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_ -timeout 180m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== RUN   TestAccDataSourceAwsEc2CoipPools_basic
=== PAUSE TestAccDataSourceAwsEc2CoipPools_basic
=== RUN   TestAccDataSourceAwsEc2CoipPools_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPools_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== RUN   TestAccDataSourceAwsEc2InstanceType_basic
=== PAUSE TestAccDataSourceAwsEc2InstanceType_basic
=== RUN   TestAccDataSourceAwsEc2InstanceType_metal
=== PAUSE TestAccDataSourceAwsEc2InstanceType_metal
=== RUN   TestAccDataSourceAwsEc2InstanceType_gpu
=== PAUSE TestAccDataSourceAwsEc2InstanceType_gpu
=== RUN   TestAccDataSourceAwsEc2InstanceType_fpga
=== PAUSE TestAccDataSourceAwsEc2InstanceType_fpga
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPools_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (1.69s)
=== CONT  TestAccDataSourceAwsEc2InstanceType_fpga
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (1.81s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (1.83s)
=== CONT  TestAccDataSourceAwsEc2InstanceType_metal
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (1.93s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn (1.94s)
=== CONT  TestAccDataSourceAwsEc2InstanceType_gpu
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (2.07s)
=== CONT  TestAccDataSourceAwsEc2InstanceType_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags (2.10s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter (0.35s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPools_Filter (0.34s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic (0.33s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (6.51s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId (6.63s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (6.65s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags (6.71s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id (6.76s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter (6.89s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (7.02s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (7.02s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPools_basic (10.50s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_basic (14.65s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_fpga (16.92s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (18.61s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_metal (16.79s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_gpu (16.67s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (18.73s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (18.74s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (19.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.112s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

Note test failure is unrelated (exists in main)

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_\|TestAccDataSourceAwsEc2CoipPools_\|TestAccAWSEc2InstanceTypeOfferingDataSource_\|TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter\|TestAccDataSourceAwsEc2InstanceType_\|TestAccDataSourceAwsEc2LocalGatewayRouteTable_\|TestAccDataSourceAwsEc2LocalGatewayRouteTables_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_\|TestAccDataSourceAwsEc2CoipPools_\|TestAccAWSEc2InstanceTypeOfferingDataSource_\|TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter\|TestAccDataSourceAwsEc2InstanceType_\|TestAccDataSourceAwsEc2LocalGatewayRouteTable_\|TestAccDataSourceAwsEc2LocalGatewayRouteTables_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_\|TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_ -timeout 180m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== RUN   TestAccDataSourceAwsEc2CoipPools_basic
=== PAUSE TestAccDataSourceAwsEc2CoipPools_basic
=== RUN   TestAccDataSourceAwsEc2CoipPools_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPools_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== RUN   TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== PAUSE TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== RUN   TestAccDataSourceAwsEc2InstanceType_basic
=== PAUSE TestAccDataSourceAwsEc2InstanceType_basic
=== RUN   TestAccDataSourceAwsEc2InstanceType_metal
=== PAUSE TestAccDataSourceAwsEc2InstanceType_metal
=== RUN   TestAccDataSourceAwsEc2InstanceType_gpu
=== PAUSE TestAccDataSourceAwsEc2InstanceType_gpu
=== RUN   TestAccDataSourceAwsEc2InstanceType_fpga
=== PAUSE TestAccDataSourceAwsEc2InstanceType_fpga
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== RUN   TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== PAUSE TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
=== CONT  TestAccDataSourceAwsEc2InstanceType_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
=== CONT  TestAccDataSourceAwsEc2InstanceType_fpga
=== CONT  TestAccDataSourceAwsEc2InstanceType_gpu
=== CONT  TestAccDataSourceAwsEc2InstanceType_metal
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Id (1.65s)
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (1.68s)
=== CONT  TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (1.76s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId (1.76s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (1.91s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_basic
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic (1.95s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_Filter
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Tags (1.96s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (2.13s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterface_Filter (2.14s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags (0.43s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (0.67s)
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (0.51s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPools_Filter (0.63s)
=== CONT  TestAccDataSourceAwsEc2CoipPools_basic
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPools_basic (0.76s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter (4.99s)
=== CONT  TestAccDataSourceAwsEc2InstanceType_basic
    data_source_aws_ec2_instance_type_test.go:12: Step 1/1 error: Check failed: Check 14/42 error: data.aws_ec2_instance_type.basic: Attribute 'free_tier_eligible' expected "true", got "false"
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (6.61s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (6.65s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (7.14s)
=== CONT  TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn (7.19s)
--- FAIL: TestAccDataSourceAwsEc2InstanceType_basic (7.62s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_gpu (11.79s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_fpga (12.29s)
--- PASS: TestAccDataSourceAwsEc2InstanceType_metal (13.15s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (13.25s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (12.32s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (14.22s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (12.82s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	17.721s
FAIL
make: *** [testacc] Error 1

@YakDriver YakDriver added this to the v3.33.0 milestone Mar 18, 2021
@YakDriver YakDriver merged commit eab5263 into main Mar 18, 2021
@YakDriver YakDriver deleted the t-ec2-errorcheck2 branch March 18, 2021 17:43
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @breathingdust