Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Support (helper/schema.Resource).DeleteWithoutTimeout in testAccCheckResourceDisappears #18398

Merged
merged 1 commit into from
Mar 30, 2021
Merged

tests/provider: Support (helper/schema.Resource).DeleteWithoutTimeout in testAccCheckResourceDisappears #18398

merged 1 commit into from
Mar 30, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #15090

Output from acceptance testing:

# Existing Delete
--- PASS: TestAccAWSXrayGroup_disappears (15.90s)

# Existing DeleteContext
--- PASS: TestAccAWSAMPWorkspace_disappears (13.63s)

@bflad
tests/provider: Support (helper/schema.Resource).DeleteWithoutTimeout…
584611c 
… in testAccCheckResourceDisappears

Reference: #15090

Output from acceptance testing:

```
# Existing Delete
--- PASS: TestAccAWSXrayGroup_disappears (15.90s)

# Existing DeleteContext
--- PASS: TestAccAWSAMPWorkspace_disappears (13.63s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Mar 25, 2021
@bflad bflad requested a review from a team as a code owner March 25, 2021 10:17
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 25, 2021
anGie44
anGie44 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice looks great! and just when i was wondering if this was already implemented 🙌

@bflad bflad merged commit 4be21e7 into main Mar 30, 2021
@bflad bflad deleted the td-testAccCheckResourceDisappears-WithoutTimeout-support branch March 30, 2021 19:02
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 30, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44