Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/cloudformation: New Resource and Data Source: aws_cloudformation_type #18579

Merged
merged 5 commits into from
Apr 20, 2021
Merged

service/cloudformation: New Resource and Data Source: aws_cloudformation_type #18579

merged 5 commits into from
Apr 20, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12583

Please note: The handler binary is not included to prevent adding a large file to the repository. The test skip messaging includes directions how to generate it locally, if desired.

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsCloudformationType_basic (145.29s)
--- PASS: TestAccAwsCloudformationType_disappears (160.15s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (145.92s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (147.60s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (146.49s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (12.57s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (144.70s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (12.46s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsCloudformationType_basic (157.19s)
--- PASS: TestAccAwsCloudformationType_disappears (147.02s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (146.99s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (159.26s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (147.32s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (18.42s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (147.18s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (18.35s)

@bflad
service/cloudformation: New Resource and Data Source: aws_cloudformat…
884a0a0 
…ion_type

Reference: #12583

Please note: The handler binary is not included to prevent adding a large file to the repository. The test skip messaging includes directions how to generate it locally, if desired.

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsCloudformationType_basic (145.29s)
--- PASS: TestAccAwsCloudformationType_disappears (160.15s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (145.92s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (147.60s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (146.49s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (12.57s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (144.70s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (12.46s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsCloudformationType_basic (157.19s)
--- PASS: TestAccAwsCloudformationType_disappears (147.02s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (146.99s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (159.26s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (147.32s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (18.42s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (147.18s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (18.35s)
```
@bflad bflad added new-resource Introduces a new resource. new-data-source Introduces a new data source. labels Apr 6, 2021
@bflad bflad requested a review from a team as a code owner April 6, 2021 04:35
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudformation Issues and PRs that pertain to the cloudformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 6, 2021
@bflad
Update CHANGELOG for 18579
9044564
@bflad
docs/resource/aws_cloudformation_type: Fix typo
c0a2fbc
@bflad
tests/data-source/aws_cloudformation_type: Fix AWSAT005 report
390ca30 
Output from acceptance testing:

```
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (11.22s)
```
@ewbankkit ewbankkit self-assigned this Apr 14, 2021
@bflad @ewbankkit
Apply suggestions from code review
8f483ff 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@ewbankkit
Copy link
Contributor

Do we want an aws_cloudformation_types (plural) data source?

@bflad
Copy link
Contributor Author

bflad commented Apr 19, 2021

@ewbankkit I can submit a followup pull request for that, if desired. No direct need/ask for it at the moment.

@ewbankkit
Copy link
Contributor

Verified acceptance tests:

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsCloudformationType_'                                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudformationType_ -timeout 180m
=== RUN   TestAccAwsCloudformationType_basic
=== PAUSE TestAccAwsCloudformationType_basic
=== RUN   TestAccAwsCloudformationType_disappears
=== PAUSE TestAccAwsCloudformationType_disappears
=== RUN   TestAccAwsCloudformationType_ExecutionRoleArn
=== PAUSE TestAccAwsCloudformationType_ExecutionRoleArn
=== RUN   TestAccAwsCloudformationType_LoggingConfig
=== PAUSE TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAwsCloudformationType_basic
=== CONT  TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAwsCloudformationType_disappears
=== CONT  TestAccAwsCloudformationType_ExecutionRoleArn
--- PASS: TestAccAwsCloudformationType_disappears (148.11s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (149.30s)
--- PASS: TestAccAwsCloudformationType_basic (152.82s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (156.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	160.156s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsCloudformationType_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudformationType_ -timeout 180m
=== RUN   TestAccAwsCloudformationType_basic
=== PAUSE TestAccAwsCloudformationType_basic
=== RUN   TestAccAwsCloudformationType_disappears
=== PAUSE TestAccAwsCloudformationType_disappears
=== RUN   TestAccAwsCloudformationType_ExecutionRoleArn
=== PAUSE TestAccAwsCloudformationType_ExecutionRoleArn
=== RUN   TestAccAwsCloudformationType_LoggingConfig
=== PAUSE TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAwsCloudformationType_basic
=== CONT  TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAwsCloudformationType_ExecutionRoleArn
=== CONT  TestAccAwsCloudformationType_disappears
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (148.50s)
--- PASS: TestAccAwsCloudformationType_disappears (149.21s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (150.82s)
--- PASS: TestAccAwsCloudformationType_basic (163.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	167.741s

ewbankkit
ewbankkit approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

Forgot verification of the data source tests 😄:

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsCloudformationTypeDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudformationTypeDataSource_ -timeout 180m
=== RUN   TestAccAwsCloudformationTypeDataSource_Arn_Private
=== PAUSE TestAccAwsCloudformationTypeDataSource_Arn_Private
=== RUN   TestAccAwsCloudformationTypeDataSource_Arn_Public
=== PAUSE TestAccAwsCloudformationTypeDataSource_Arn_Public
=== RUN   TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== PAUSE TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== RUN   TestAccAwsCloudformationTypeDataSource_TypeName_Public
=== PAUSE TestAccAwsCloudformationTypeDataSource_TypeName_Public
=== CONT  TestAccAwsCloudformationTypeDataSource_Arn_Private
=== CONT  TestAccAwsCloudformationTypeDataSource_Arn_Public
=== CONT  TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== CONT  TestAccAwsCloudformationTypeDataSource_TypeName_Public
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (11.37s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (11.48s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (158.65s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (169.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	172.999s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsCloudformationTypeDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudformationTypeDataSource_ -timeout 180m
=== RUN   TestAccAwsCloudformationTypeDataSource_Arn_Private
=== PAUSE TestAccAwsCloudformationTypeDataSource_Arn_Private
=== RUN   TestAccAwsCloudformationTypeDataSource_Arn_Public
=== PAUSE TestAccAwsCloudformationTypeDataSource_Arn_Public
=== RUN   TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== PAUSE TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== RUN   TestAccAwsCloudformationTypeDataSource_TypeName_Public
=== PAUSE TestAccAwsCloudformationTypeDataSource_TypeName_Public
=== CONT  TestAccAwsCloudformationTypeDataSource_Arn_Private
=== CONT  TestAccAwsCloudformationTypeDataSource_TypeName_Public
=== CONT  TestAccAwsCloudformationTypeDataSource_TypeName_Private
=== CONT  TestAccAwsCloudformationTypeDataSource_Arn_Public
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (14.37s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (14.53s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (147.57s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (147.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	150.862s

@bflad bflad merged commit a803491 into main Apr 20, 2021
@bflad bflad deleted the f-cloudformation-types branch April 20, 2021 13:41
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 20, 2021
github-actions bot pushed a commit that referenced this pull request Apr 20, 2021
Update CHANGELOG.md for #18579
17f30ea
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

Add Cloudformation RegisterType
2 participants
@bflad @ewbankkit